feat: Canonicalize the OCR languages across all engines according to the BCP-47 standard - #4075
Draft
nikos-livathinos wants to merge 18 commits into
Draft
feat: Canonicalize the OCR languages across all engines according to the BCP-47 standard#4075nikos-livathinos wants to merge 18 commits into
nikos-livathinos wants to merge 18 commits into
Conversation
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
…s either the BCP-47 standard or the native input language supported by each OCR engine. Update the tests. Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
nikos-livathinos
marked this pull request as draft
August 25, 2026 17:05
Contributor
|
✅ DCO Check Passed Thanks @nikos-livathinos, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
… styling free. This is needed in order to match the expected values Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
- Fix the advertised language lists (EasyOCR, Tesserct, ocrmac) - Make --ocr-lang "" reach the engine as lang=[] - Simplify the implementation of OcrLanguageResolver Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
…nonicalization mode, simplify code Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
nikos-livathinos
marked this pull request as ready for review
August 28, 2026 09:36
nikos-livathinos
marked this pull request as draft
August 28, 2026 15:40
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
… the native tokens. Still WIP Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
…anguage Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of the discussion #3915
Checklist: