Repository navigation
feat(push): deprecate --ignore-push-failures in favor of --ignore-missing - #14354
Merged
Merged
Conversation
…sing --ignore-push-failures swallows every push error, including authentication and registry ones, which hides real problems when the only expectation is that some images were never built. --ignore-missing now covers that case on its own. Keep the flag working but mark it deprecated: it prints a warning and is hidden from help and docs. Make it mutually exclusive with --ignore-missing so the two cannot be combined ambiguously. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Mark
docker compose push --ignore-push-failuresas deprecated now that--ignore-missingexists (#14341). The flag still works and prints a deprecation warning, but it is hidden from help and docs. It can no longer be combined with--ignore-missing.Related issue
Follow up of #14341
(not mandatory) A picture of a cute animal, if possible in relation to what you did
