Skip to content

Use docker-init -s to fix zombie containerd-shim processes in rootless mode #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okhowang wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Use docker-init -s to fix zombie containerd-shim processes in rootless mode #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dockerd-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ if [ "$1" = 'dockerd' ]; then
find /run /var/run -iname 'docker*.pid' -delete || :

# XXX inject "docker-init" (tini) as pid1 to workaround https://github.com/docker-library/docker/issues/318 (zombie container-shim processes)
set -- docker-init -- "$@"
# use -s so docker-init also registers as a subreaper and reaps orphaned processes (e.g. containerd-shim) even when it isn't PID 1, which is the case in rootless mode where rootlesskit does not create a PID namespace by default
set -- docker-init -s -- "$@"

iptablesLegacy=
if [ -n "${DOCKER_IPTABLES_LEGACY+x}" ]; then
Expand Down