Skip to content
This repository was archived by the owner on May 4, 2021. It is now read-only.

Add log rotation and volume mount for apache#11

Open
kryton wants to merge 3 commits into
docker-archive:masterfrom
kryton:master
Open

Add log rotation and volume mount for apache#11
kryton wants to merge 3 commits into
docker-archive:masterfrom
kryton:master

Conversation

@kryton

@kryton kryton commented Feb 17, 2015

Copy link
Copy Markdown

apache generates log files, which if left unchecked, will grow until you run out of disk.
this patch does two things.

  1. uses log rotation (via logrotate) to create daily log files
  2. exposes the volume so that other programs/containers can purge/read these files

@fermayo

fermayo commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

Hi krtyon,

Why did you modify run.sh?

@kryton

kryton commented Feb 20, 2015

Copy link
Copy Markdown
Author

Hi Fermayo.
it was a mistake. (i typically use 'run.sh' to run docker containers, not in them.. )
I reverted it.

@Potherca

Copy link
Copy Markdown

👍

@kryton

kryton commented Jun 3, 2015

Copy link
Copy Markdown
Author

fermayo.. any chance of pushing this through??

@fermayo

fermayo commented Jun 3, 2015

Copy link
Copy Markdown
Contributor

Hi there! You are still pushing a build.sh file which shouldn't be part of this PR. Can you please remove that file and squash your commits?
@tifayuki can you please review?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants