Raise notification on job completion and improve S3 wiring#45
Merged
Conversation
S3StorageOptions was a duplicate of S3TextStoreOptions introduced when wiring up config. Register S3TextStoreOptions via Configure<> so S3TextStore can accept IOptions<S3TextStoreOptions> and be created via ActivatorUtilities, consistent with SnsJobNotifier. Also conditionally register AWS services to avoid credential chain hanging in tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Consolidates all IServiceCollection extension methods into a single ServiceCollectionExtensions class, replacing the separate HangfireServiceCollectionExtensions file. Adds AddAwsServices, AddFetchingServices, AddTextStorage, and AddNotificationServices to keep Program.cs a clean list of Add* calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add dotnet format analyzers step to CI to enforce editorconfig rules (e.g. csharp_prefer_braces = when_multiline) that the pre-commit hook misses. Fix the existing violation in ServiceCollectionExtensions.cs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullJobNotifier)AddAWSService<IAmazonS3>()withIOptions<S3TextStoreOptions>injection, removing the duplicateS3StorageOptionsclassProgram.csintoServiceCollectionExtensionsalongside the existing Hangfire extensionsdotnet format analyzersCI step to enforce editorconfig rules (e.g.csharp_prefer_braces) that the pre-commit hook missesdocs/builder-api.mdTest plan
dotnet test src/TextServices.slnTextServices:Notifications:TopicArnunset, jobs complete without error (NullJobNotifier)TextServices:Storage:S3:BucketNameset, S3TextStore is used; without it, FileSystemTextStore is used🤖 Generated with Claude Code