Skip to content

Fix build errors in ComposeOrchestrator network attachment and container config - #15

Merged
djpfs merged 4 commits into
mainfrom
copilot/fix-github-actions-job
Aug 17, 2026
Merged

Fix build errors in ComposeOrchestrator network attachment and container config#15
djpfs merged 4 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Two compile errors in ComposeOrchestrator.swift were breaking the macOS CI build.

Changes

  • Missing return in map closure — AttachmentConfiguration(...) was constructed but not returned, causing the closure to return Void and networks to be inferred as [()] instead of [AttachmentConfiguration]
  • Wrong argument order in ContainerConfiguration initializer — useInit: was placed after privileged:, violating the declared parameter order
// Before
let networks = configuredNetworks.enumerated().map { index, network in
    let attachmentHostname = ...
    AttachmentConfiguration(...)  // result discarded, closure returns ()
}

// After
let networks = configuredNetworks.enumerated().map { index, network in
    let attachmentHostname = ...
    return AttachmentConfiguration(...)  // correctly returned
}
// Before
readOnly: service.readOnly,
privileged: service.privileged,
useInit: service.initEnabled,  // wrong order

// After
readOnly: service.readOnly,
useInit: service.initEnabled,  // correct order per declaration
privileged: service.privileged,

@djpfs
Fix compile errors in ComposeOrchestrator.swift
4fa5cc2 
Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job 'Build & Test (macOS)' Fix build errors in ComposeOrchestrator network attachment and container config Aug 14, 2026
Copilot AI requested a review from djpfs August 14, 2026 13:48
@djpfs

djpfs commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Corrija isso @copilot

[129/136] Emitting module ComposeEngine
[130/136] Compiling ComposeEngine ComposeEngine.swift
/Users/runner/work/Macker/Macker/Sources/ComposeEngine/ComposeOrchestrator.swift:824:13: error: argument 'capAdd' must precede argument 'privileged'
822 | useInit: service.initEnabled,
823 | privileged: service.privileged,
824 | capAdd: service.capAdd,
| - error: argument 'capAdd' must precede argument 'privileged' 825 | capDrop: service.capDrop, 826 | securityOptions: service.securityOpt, [131/136] Compiling ComposeEngine ComposeOrchestrator.swift /Users/runner/work/Macker/Macker/Sources/ComposeEngine/ComposeOrchestrator.swift:824:13: error: argument 'capAdd' must precede argument 'privileged' 822 | useInit: service.initEnabled, 823 | privileged: service.privileged, 824 | capAdd: service.capAdd, | - error: argument 'capAdd' must precede argument 'privileged'
825 | capDrop: service.capDrop,
826 | securityOptions: service.securityOpt,
[132/136] Compiling ComposeEngine ComposeParser.swift
[133/136] Compiling ComposeEngine ComposeModels.swift
[134/137] Compiling ComposeEngine ServiceResolver.swift

djpfs
djpfs requested changes Aug 14, 2026
View reviewed changes

@djpfs djpfs left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolva os problemas no Build da pipeline

@djpfs
Fix argument order: capAdd/capDrop must precede privileged in Contain…
0c2a452 
…erConfiguration init

Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>

Copilot AI commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Corrija isso @copilot

[129/136] Emitting module ComposeEngine
...

Fixed in the latest commit. capAdd and capDrop now appear before privileged, matching the declared parameter order in ContainerConfiguration.

Copilot AI requested a review from djpfs August 14, 2026 15:58
djpfs
djpfs requested changes Aug 14, 2026
View reviewed changes

@djpfs djpfs left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erro nvoamente

Test Case '-[DockerShimTests.DockerShimTests testSecretCreateCommand]' started.
/Users/runner/work/Macker/Macker/Tests/DockerShimTests/DockerShimTests.swift:114: error: -[DockerShimTests.DockerShimTests testSecretCreateCommand] : XCTAssertEqual failed: ("["db-pass"]") is not equal to ("["db-pass", "-"]")
Test Case '-[DockerShimTests.DockerShimTests testSecretCreateCommand]' failed (0.316 seconds).
Test Suite 'DockerShimTests' failed at 2026-08-14 16:18:56.908.
Executed 19 tests, with 1 failure (0 unexpected) in 0.319 (0.319) seconds
Test Suite 'HotReloadServiceTests' started at 2026-08-14 16:18:56.908.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testBatchesByContainer]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testBatchesByContainer]' passed (0.001 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testContentChangeFlags]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testContentChangeFlags]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresMetadataOnlyChanges]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresMetadataOnlyChanges]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresPathsOutsideMounts]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresPathsOutsideMounts]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapHostPathToContainerPath]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapHostPathToContainerPath]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapMountRootItself]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapMountRootItself]' passed (0.000 seconds).
Test Suite 'HotReloadServiceTests' passed at 2026-08-14 16:18:56.910.
Executed 6 tests, with 0 failures (0 unexpected) in 0.002 (0.002) seconds
Test Suite 'IntegrationTests' started at 2026-08-14 16:18:56.910.
Test Case '-[IntegrationTests.IntegrationTests testNetworkList]' started.
/Users/runner/work/Macker/Macker/Tests/IntegrationTests/IntegrationTests.swift:16: -[IntegrationTests.IntegrationTests testNetworkList] : Test skipped - container runtime not available (set APPLE_CONTAINER_RUNTIME=1)
Test Case '-[IntegrationTests.IntegrationTests testNetworkList]' skipped (0.001 seconds).
Test Case '-[IntegrationTests.IntegrationTests testPing]' started.
/Users/runner/work/Macker/Macker/Tests/IntegrationTests/IntegrationTests.swift:16: -[IntegrationTests.IntegrationTests testPing] : Test skipped - container runtime not available (set APPLE_CONTAINER_RUNTIME=1)
Test Case '-[IntegrationTests.IntegrationTests testPing]' skipped (0.000 seconds).
Test Suite 'IntegrationTests' passed at 2026-08-14 16:18:56.911.
Executed 2 tests, with 2 tests skipped and 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'KernelModelTests' started at 2026-08-14 16:18:56.911.
Test Case '-[ContainerBackendTests.KernelModelTests testKernelRoundTrip]' started.
Test Case '-[ContainerBackendTests.KernelModelTests testKernelRoundTrip]' passed (0.001 seconds).
Test Case '-[ContainerBackendTests.KernelModelTests testPlatformDescription]' started.
Test Case '-[ContainerBackendTests.KernelModelTests testPlatformDescription]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.KernelModelTests testSystemPlatformJSONKeyNames]' started.
Test Case '-[ContainerBackendTests.KernelModelTests testSystemPlatformJSONKeyNames]' passed (0.000 seconds).
Test Suite 'KernelModelTests' passed at 2026-08-14 16:18:56.913.
Executed 3 tests, with 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'SecurityHardeningTests' started at 2026-08-14 16:18:56.913.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testContainerConfigurationDefaultsSecurityFields]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testContainerConfigurationDefaultsSecurityFields]' passed (0.002 seconds).
Test Case '-[ContainerBackendTests.SecurityHardeningTests testParseTrivyReport]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testParseTrivyReport]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentFromKeychainReference]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentFromKeychainReference]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentThrowsWhenSecretMissing]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentThrowsWhenSecretMissing]' passed (0.000 seconds).
Test Suite 'SecurityHardeningTests' passed at 2026-08-14 16:18:56.915.
Executed 4 tests, with 0 failures (0 unexpected) in 0.002 (0.003) seconds
Test Suite 'XPCMessageTests' started at 2026-08-14 16:18:56.915.
Test Case '-[ContainerBackendTests.XPCMessageTests testJSONRoundTrip]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testJSONRoundTrip]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetBool]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetBool]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetData]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetData]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetString]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetString]' passed (0.000 seconds).
Test Suite 'XPCMessageTests' passed at 2026-08-14 16:18:56.916.
Executed 4 tests, with 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'mackerPackageTests.xctest' failed at 2026-08-14 16:18:56.916.
Executed 77 tests, with 2 tests skipped and 1 failure (0 unexpected) in 0.353 (0.356) seconds
Test Suite 'All tests' failed at 2026-08-14 16:18:56.916.
Executed 77 tests, with 2 tests skipped and 1 failure (0 unexpected) in 0.353 (0.357) seconds
◇ Test run started.
↳ Testing Library Version: 124.4
↳ Target Platform: arm64e-apple-macos14.0
✔ Test run with 0 tests passed after 0.001 seconds.
Error: Process completed with exit code 1.

Copilot AI requested a review from djpfs August 14, 2026 16:21
djpfs
djpfs requested changes Aug 14, 2026
View reviewed changes

@djpfs djpfs left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rro nvoamente

Test Case '-[DockerShimTests.DockerShimTests testSecretCreateCommand]' started.
/Users/runner/work/Macker/Macker/Tests/DockerShimTests/DockerShimTests.swift:114: error: -[DockerShimTests.DockerShimTests testSecretCreateCommand] : XCTAssertEqual failed: ("["db-pass"]") is not equal to ("["db-pass", "-"]")
Test Case '-[DockerShimTests.DockerShimTests testSecretCreateCommand]' failed (0.316 seconds).
Test Suite 'DockerShimTests' failed at 2026-08-14 16:18:56.908.
Executed 19 tests, with 1 failure (0 unexpected) in 0.319 (0.319) seconds
Test Suite 'HotReloadServiceTests' started at 2026-08-14 16:18:56.908.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testBatchesByContainer]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testBatchesByContainer]' passed (0.001 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testContentChangeFlags]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testContentChangeFlags]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresMetadataOnlyChanges]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresMetadataOnlyChanges]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresPathsOutsideMounts]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testIgnoresPathsOutsideMounts]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapHostPathToContainerPath]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapHostPathToContainerPath]' passed (0.000 seconds).
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapMountRootItself]' started.
Test Case '-[HotReloadServiceTests.HotReloadServiceTests testMapMountRootItself]' passed (0.000 seconds).
Test Suite 'HotReloadServiceTests' passed at 2026-08-14 16:18:56.910.
Executed 6 tests, with 0 failures (0 unexpected) in 0.002 (0.002) seconds
Test Suite 'IntegrationTests' started at 2026-08-14 16:18:56.910.
Test Case '-[IntegrationTests.IntegrationTests testNetworkList]' started.
/Users/runner/work/Macker/Macker/Tests/IntegrationTests/IntegrationTests.swift:16: -[IntegrationTests.IntegrationTests testNetworkList] : Test skipped - container runtime not available (set APPLE_CONTAINER_RUNTIME=1)
Test Case '-[IntegrationTests.IntegrationTests testNetworkList]' skipped (0.001 seconds).
Test Case '-[IntegrationTests.IntegrationTests testPing]' started.
/Users/runner/work/Macker/Macker/Tests/IntegrationTests/IntegrationTests.swift:16: -[IntegrationTests.IntegrationTests testPing] : Test skipped - container runtime not available (set APPLE_CONTAINER_RUNTIME=1)
Test Case '-[IntegrationTests.IntegrationTests testPing]' skipped (0.000 seconds).
Test Suite 'IntegrationTests' passed at 2026-08-14 16:18:56.911.
Executed 2 tests, with 2 tests skipped and 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'KernelModelTests' started at 2026-08-14 16:18:56.911.
Test Case '-[ContainerBackendTests.KernelModelTests testKernelRoundTrip]' started.
Test Case '-[ContainerBackendTests.KernelModelTests testKernelRoundTrip]' passed (0.001 seconds).
Test Case '-[ContainerBackendTests.KernelModelTests testPlatformDescription]' started.
Test Case '-[ContainerBackendTests.KernelModelTests testPlatformDescription]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.KernelModelTests testSystemPlatformJSONKeyNames]' started.
Test Case '-[ContainerBackendTests.KernelModelTests testSystemPlatformJSONKeyNames]' passed (0.000 seconds).
Test Suite 'KernelModelTests' passed at 2026-08-14 16:18:56.913.
Executed 3 tests, with 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'SecurityHardeningTests' started at 2026-08-14 16:18:56.913.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testContainerConfigurationDefaultsSecurityFields]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testContainerConfigurationDefaultsSecurityFields]' passed (0.002 seconds).
Test Case '-[ContainerBackendTests.SecurityHardeningTests testParseTrivyReport]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testParseTrivyReport]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentFromKeychainReference]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentFromKeychainReference]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentThrowsWhenSecretMissing]' started.
Test Case '-[ContainerBackendTests.SecurityHardeningTests testResolveEnvironmentThrowsWhenSecretMissing]' passed (0.000 seconds).
Test Suite 'SecurityHardeningTests' passed at 2026-08-14 16:18:56.915.
Executed 4 tests, with 0 failures (0 unexpected) in 0.002 (0.003) seconds
Test Suite 'XPCMessageTests' started at 2026-08-14 16:18:56.915.
Test Case '-[ContainerBackendTests.XPCMessageTests testJSONRoundTrip]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testJSONRoundTrip]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetBool]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetBool]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetData]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetData]' passed (0.000 seconds).
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetString]' started.
Test Case '-[ContainerBackendTests.XPCMessageTests testSetAndGetString]' passed (0.000 seconds).
Test Suite 'XPCMessageTests' passed at 2026-08-14 16:18:56.916.
Executed 4 tests, with 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'mackerPackageTests.xctest' failed at 2026-08-14 16:18:56.916.
Executed 77 tests, with 2 tests skipped and 1 failure (0 unexpected) in 0.353 (0.356) seconds
Test Suite 'All tests' failed at 2026-08-14 16:18:56.916.
Executed 77 tests, with 2 tests skipped and 1 failure (0 unexpected) in 0.353 (0.357) seconds
◇ Test run started.
↳ Testing Library Version: 124.4
↳ Target Platform: arm64e-apple-macos14.0
✔ Test run with 0 tests passed after 0.001 seconds.
Error: Process completed with exit code 1.

@djpfs
Fix DockerCommand parser treating bare '-' (stdin) as a flag instead …
8036250 
…of positional

Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>
Copilot AI requested a review from djpfs August 14, 2026 16:59
@djpfs
djpfs marked this pull request as ready for review August 17, 2026 01:08
@djpfs
djpfs merged commit a868178 into main Aug 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@djpfs djpfs djpfs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@djpfs djpfs

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djpfs