Expand Compose capabilities and image management - #12
Merged
Conversation
Add secure registry login and Dockerfile builds with cache control.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
djpfs
August 14, 2026 02:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the ComposeEngine parser to support profile-aware service filtering and service-level secrets/configs attachments (including validation), and extends the ContainerBackend to support secure registry login via stdin and image builds via the container CLI.
Changes:
- Add
profilesfiltering toComposeParser.parse(...)and validate referencedsecrets/configs. - Extend Compose models to decode
secrets/configson services and add tests covering profiles + attachments. - Add registry login using
--password-stdin, image build support, and stdin support inProcessRunner.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/ComposeEngineTests/ComposeEngineTests.swift | Adds coverage for profiles + service attachments in parsing/validation. |
| Sources/ContainerBackend/ProcessRunner.swift | Adds optional stdin support for CLI invocations. |
| Sources/ContainerBackend/ImageService.swift | Adds registry login via stdin and introduces an image build API. |
| Sources/ComposeEngine/Models/ComposeModels.swift | Adds secrets/configs fields to ServiceConfig decoding/model. |
| Sources/ComposeEngine/ComposeParser.swift | Adds profile filtering and validates secret/config references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…omments and validation tests Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>
Contributor
Author
All review comments have been addressed in the latest commit:
|
Co-authored-by: djpfs <43576725+djpfs@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
djpfs
marked this pull request as ready for review
August 14, 2026 03:12
djpfs
approved these changes
Aug 14, 2026
djpfs
self-requested a review
August 14, 2026 03:34
djpfs
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR advances the first two improvement areas: broader Docker Compose support and stronger image/registry workflows. It adds profile-aware parsing, service attachments, secure registry authentication, and configurable image builds.
Compose engine
secretsandconfigs.Image management
ProcessRunner.Example: