fix: Check parameter validity by type name - #2577
Merged
Merged
Conversation
trisyoungs
changed the title
trisyoungs
marked this pull request as ready for review
August 11, 2026 08:33
rprospero
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick PR to change the checks made in
ParameterBase::getandParameterBase::setto explicitly match the names oftype_ids rather than just comparingstd::type_indexobjects. The latter would cause unit tests to fail on OSX due to different hash_codes for the same type being generated (presumably due to some scope / forward declaration issue on that platform).