Skip to content

[SEC-2830] mark drupal 11.3 with php 8.4 not experimental#32

Merged
JojoVes merged 1 commit into
mainfrom
d11dot3/prep-for-updates
May 15, 2026
Merged

[SEC-2830] mark drupal 11.3 with php 8.4 not experimental#32
JojoVes merged 1 commit into
mainfrom
d11dot3/prep-for-updates

Conversation

@JojoVes
Copy link
Copy Markdown
Contributor

@JojoVes JojoVes commented May 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated testing configuration to mark Drupal 11.3 with PHP 8.4 support as stable rather than experimental.

Review Change Stack

@JojoVes JojoVes added the minor Added functionality that is backwards compatible. label May 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0058b60e-c8d5-484e-b710-250bc800e112

📥 Commits

Reviewing files that changed from the base of the PR and between e47792a and bd604a5.

📒 Files selected for processing (1)
  • .github/workflows/phpunit.yml

📝 Walkthrough

Walkthrough

This PR updates the PHPUnit GitHub Actions workflow matrix configuration to mark the Drupal 11.3 / PHP 8.4 test combination as non-experimental. The experimental flag is changed from true to false, which updates the continue-on-error behavior for that specific matrix entry in the test workflow.

Changes

PHPUnit Workflow Matrix Update

Layer / File(s) Summary
Experimental flag update for Drupal 11.3 / PHP 8.4
.github/workflows/phpunit.yml
The experimental flag in the job matrix include entry is changed from true to false for the drupal-version: '11.3' and php-version: '8.4' combination, affecting the continue-on-error behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • discoverygarden/phpunit-action#29: Modifies .github/workflows/phpunit.yml's PHPUnit version matrix, specifically changing the experimental flag values for certain drupal-version/php-version combinations including 11.x/8.4 coverage.
  • discoverygarden/phpunit-action#26: Modifies the .github/workflows/phpunit.yml PHPUnit test matrix—specifically the matrix.experimental flag/entries—directly related to the experimental-toggling work.

Suggested reviewers

  • adam-vessey

Poem

🐰 A flag flips from true to false, so neat,
The Drupal 8.4 dance is now complete,
No longer experimental, tried and true,
The workflow matrix marches through and through! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: marking the Drupal 11.3 with PHP 8.4 combination as non-experimental in the workflow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch d11dot3/prep-for-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JojoVes JojoVes merged commit fa30bf9 into main May 15, 2026
2 checks passed
@JojoVes JojoVes deleted the d11dot3/prep-for-updates branch May 15, 2026 13:25
@github-actions
Copy link
Copy Markdown

Tag generated by PR: v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Added functionality that is backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants