Skip to content

[SUP-7562] Adjust VERSION_SPEC#31

Merged
JojoVes merged 4 commits into
mainfrom
adam-vessey-patch-1
Apr 22, 2026
Merged

[SUP-7562] Adjust VERSION_SPEC#31
JojoVes merged 4 commits into
mainfrom
adam-vessey-patch-1

Conversation

@adam-vessey
Copy link
Copy Markdown
Contributor

@adam-vessey adam-vessey commented Apr 2, 2026

It appears that dispatched workflows don't expose things in quite the same way.

Summary by CodeRabbit

  • Chores
    • Standardized workflow configuration formatting with consistent line endings
    • Enhanced package version selection logic to dynamically vary based on workflow trigger type and Git reference type, differentiating between manual dispatches and automated executions

It appears that dispatched workflows don't expose things in quite the same way.
@adam-vessey adam-vessey added the patch Backwards compatible bug fixes. label Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Updated workflow file formatting with Windows-style line endings and YAML normalization, and modified composer package version specification logic to conditionally use different GitHub references based on event type (workflow_dispatch vs. others).

Changes

Cohort / File(s) Summary
Workflow Serialization
.github/workflows/phpunit.yml
Re-serialized with Windows-style line endings (\r\n) and YAML formatting normalization; functional logic and workflow structure remain unchanged.
Version Specification Logic
action.yml
Modified VERSION_SPEC determination: for workflow_dispatch events on branches, uses dev-${{ github.ref_name }}; otherwise uses ${{ github.ref_name }} or dev-${{ github.sha }} based on event type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • SEC-1684: Fix/update matrix #26: Modifies VERSION_SPEC logic for composer package versions in action.yml with related conditional branching on GitHub event types.

Suggested reviewers

  • jordandukart

Poem

🐰 A rabbit hops through GitHub's flow,
Where version specs now smartly know,
When to branch and when to sha,
The composer songs go la-di-da! 🎵

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references the main change: adjusting VERSION_SPEC logic to handle dispatched workflows differently.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adam-vessey-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this got reformatted or whatever?

@JojoVes JojoVes changed the title Adjust VERSION_SPEC [SUP-7562] Adjust VERSION_SPEC Apr 22, 2026
Comment thread .github/workflows/phpunit.yml Outdated
apt-get install -y postgresql-client
PGHOST=postgres PGUSER=drupal PGPASSWORD=drupal psql --command='CREATE EXTENSION pg_trgm;' drupal
- name: Run PHPUnit Action
uses: discoverygarden/phpunit-action@adam-vessey-patch-1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be pointed back at the version that will be minted, prior to merging.

Comment thread .github/workflows/phpunit.yml Outdated
@JojoVes JojoVes merged commit e47792a into main Apr 22, 2026
1 of 2 checks passed
@JojoVes JojoVes deleted the adam-vessey-patch-1 branch April 22, 2026 15:46
@github-actions
Copy link
Copy Markdown

Tag generated by PR: v1.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Backwards compatible bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants