FEATURE: Allow editing grouping pattern before submitting#263
Merged
Conversation
pmusaraj
commented
Apr 30, 2026
| spawn( | ||
| "cd website && LOGSTER_ENV=development BUNDLE_GEMFILE=Gemfile bundle exec rackup --host 0.0.0.0", | ||
| ) | ||
| pid = spawn("cd website && LOGSTER_ENV=development BUNDLE_GEMFILE=Gemfile bundle exec puma") |
Contributor
Author
There was a problem hiding this comment.
Rackup is no longer shipped with rack, the recommendation is to stop relying on it in libraries: https://github.com/rack/rackup#soft-deprecation
pmusaraj
commented
Apr 30, 2026
|
|
||
| group :development, :test do | ||
| gem "rails", ">= 6.1" | ||
| gem "rubocop-capybara", "< 2.23.0" |
pmusaraj
commented
Apr 30, 2026
| require "minitest/autorun" | ||
| require "minitest/pride" | ||
|
|
||
| module StubSupport |
Contributor
Author
There was a problem hiding this comment.
Needed due to upstream changes in minitest.
Contributor
There was a problem hiding this comment.
we'll need to do some cleanup of logster codebase at some point 😅
pmusaraj
commented
Apr 30, 2026
| def to_json(opts = nil) | ||
| exclude_env = Hash === opts && opts.delete(:exclude_env) | ||
| JSON.fast_generate(to_h(exclude_env: exclude_env), opts) | ||
| JSON.generate(to_h(exclude_env: exclude_env), opts) |
Contributor
Author
There was a problem hiding this comment.
JSON.fast_generate triggered deprecation notices in test runs.
cvx
approved these changes
Apr 30, 2026
| require "minitest/autorun" | ||
| require "minitest/pride" | ||
|
|
||
| module StubSupport |
Contributor
There was a problem hiding this comment.
we'll need to do some cleanup of logster codebase at some point 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows an editable pattern in a dialog before submitting when grouping from the main logs page.
Had to make a few unrelated changes to fix linting and test runs.