Add support for DogStatsD distributions - #12
Merged
Merged
Conversation
Author
|
cc'ing @ollien as well, with a gentle ping 😄 |
|
Hey @whatyouhide! Sorry that this fell through the cracks. This looks perfectly cromulent, and I gave it a quick test locally and it works as advertised. Thank you for the contribution! |
|
@whatyouhide This is available in 1.9.0! |
Author
|
Oh wow this is amazing! Thanks @ollien 💟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all, thanks for all the great changes to Statix.
We're heavy Datadog users and we would really love to be able to report distributions to Datadog, for a variety of reasons.
I'm not sure if you're willing to support something that is not supported in standard StatsD, but it's a pretty tiny change all things considered, and it's obviously opt-in as people wouldn't call it unless they're using Datadog. I think #11 also counts as "precedent" of supporting DogStatsD features here.
Thoughts? 🙃
cc @sanchda