feat(todos): add 'cancelled' status (V1 cancel capability) - #4
Merged
Merged
Conversation
Phase 2 of the vNext plan — advances the CLI's V1 orchestration core. The
ROADMAP-V2 V1 DoD calls for todo cancel/pause/resume, but TodoStatus only had
pending|in_progress|completed. Added a 'cancelled' status:
- TodoStatus, STATUS_MARK ([-]), VALID_STATUS, the parse-error message, and the
todo_write tool schema enum all now include 'cancelled'.
- render() surfaces cancelled items separately so progress stays honest
("2/5 done, 1 cancelled") — cancelled is resolved but not "done".
- protocol.ts now imports TodoStatus instead of re-declaring the narrow union,
so the wire type can't drift from the model again.
3 new tests (accept+render, no-suffix-when-none, unknown-status message). tsc
clean; todos/orchestration/serve-protocol suites green. The 5 unrelated
pre-existing Windows-env failures (bwrap/atomic-write/secrets) are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the vNext plan — advances the CLI's V1 orchestration core. The V1 DoD calls for todo cancel/pause/resume, but TodoStatus lacked 'cancelled'. Added it across the type, status mark, validation, tool schema, and render (surfaces '2/5 done, 1 cancelled'). protocol.ts now reuses TodoStatus so the wire type can't drift. 3 new tests; tsc clean; affected suites green. The 5 pre-existing Windows-env failures are unrelated.