docs(intent): deleting a payment gives its allocation back (#7061) - #228
Merged
Conversation
The settlements reference said the spread handler is bound to the payment's create and its update; the platform now also binds its delete, removing the payment's junction rows so the paid roll-up recomputes and the invoice relinquishes PAID. Records why nothing else could do it: no FK cascade, and a cross-model payment's owner does not own the junction rows. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to eclipse-dirigible/dirigible#7064.
The
settlementssection of the DSL reference described the spread handler as bound to the payment's create and its update. The platform now binds its delete as well: a further handler removes every junction row of the deleted payment through the junction repository, so thepaidroll-up recomputes and the invoice relinquishes PAID / PARTIAL exactly as when an allocation row is deleted by hand.The paragraph also records why nothing else could do it - a foreign key never becomes a database constraint on this platform, so there is no cascade, and a cross-model payment's owner knows nothing of the settlement and does not own the junction rows - which is the failure the rows caused: they outlived the payment as orphans and the invoice stayed settled forever.
npm run docs:build: clean.