Do not automatically set attributes.windowWidth and attributes.windowHeight.#54
Open
EricPei20 wants to merge 1 commit into
Open
Do not automatically set attributes.windowWidth and attributes.windowHeight.#54EricPei20 wants to merge 1 commit into
EricPei20 wants to merge 1 commit into
Conversation
CoolFanyu
reviewed
Jun 16, 2026
CoolFanyu
left a comment
CoolFanyu
left a comment
Collaborator
There was a problem hiding this comment.
I agree with Eric's change since the GetResult function will get different types of images, set the windows size to a fixed value could cause problems. DE-Server will set the window size automatically if user don't set it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes implicit client-side behavior that automatically set Attributes.windowWidth/windowHeight (and corresponding Client.width/height) when attributes is None or "auto", leaving window sizing fully controlled by the caller or the server response.
Changes:
- Removed auto-population of
attributes.windowWidth/windowHeightinget_result()forVIRTUAL_IMAGE*/EXTERNAL_IMAGE*frame types. - Removed pre-response overrides of
self.width/self.heightbased on requested window sizes. - Deleted
_get_auto_attributes()and updatedget_image()to use a plainAttributes()instance whenattributes == "auto".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1595
to
1596
| if attributes is None or attributes == "auto": | ||
| attributes = Attributes(**kwargs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.