fix: restore totalCost undefined guard - #181
Merged
Merged
Conversation
FB-15a split rewrote 175 undefined guard as ?? 0, silently recording unknown pricing as 0. restore reviewer-approved guard: only add when cost defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix
restore
getTotalCost()undefined guard inTaskRequestLoop.what
PR #170 split rewrote #175 guard:
this silently records unknown pricing as
0.change back to:
StreamingMetricsManagerreturnsundefinedfor unknown pricing,0only when model explicitly free, and actual number for provider cost or computed paid cost. only add when defined.test
src/core/task/__tests__/StreamingMetricsManager.test.tspassessrc/core/task/__tests__/TaskState.test.tspassesnpx tsc --noEmitclean except pre-existingsrc/shared/storage/types.ts(14,2)errornpx biome check src/core/task/TaskRequestLoop.tsreports 2 pre-existing formatter/import-sort errors also on master