test: Task abort/status transitions (FB-14b) - #169
Merged
Conversation
Node has node:sqlite at runtime but bundled @types/node lacks it; declares the subset used by SymbolIndexDatabase (DatabaseSync: prepare/exec/close; StatementSync: get/all/iterate/run).
Tests resolve 'vscode' to cli/src/vscode-shim.ts (paths alias), so the LanguageModel API members must live there (a .d.ts augmentation never merged under ts-node/unit-test resolution). Add LanguageModelChatSelector, TextPart/ToolCallPart/ToolResultPart, ChatMessage/Role, Chat/ChatResponse/ RequestOptions, lm.selectChatModels as real minimal classes.
mocha harness redirects 'vscode' to src/test/vscode-mock.ts (require hook). It had the LM part classes but not LanguageModelChatSelector, which types.ts / state-keys / vscode-lm reference. Unblocks those tests.
send() returns { stream: AsyncIterable } but the constructor expects
AsyncIterable directly. Unwrap to .stream.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- augment @types/vscode with LM members so import("vscode") type-refs resolve.
- ts-node moduleResolution node (was Bundler, invalid for commonjs) so
@core/@shared resolve via tsconfig-paths at runtime.
Unblocks bedrock/StateManager/context suites (FU-4).
Owner
|
should be good to merge after 166 |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FB-14b (test net for FB-15a):
TaskAbort.test.tscoveringTask.abortTask()status transitions (→ CANCELLING, delegation to lifecycleManager) viaObject.create(Task.prototype)with stubbed deps.Dependencies
Requires #166 (test-compilation unblock) — the test only runs after #166 merges. Stacked on it until then.
Verification
tscclean; runs green once the FU-4 env fix (#166) is present.Closes FB-14b (FIX-BACKLOG).