Closes #68 Pre-fix, Makefile:38 ran `go build -trimpath -ldflags "-s -w" -o bin/nodeup ./cmd/nodeup` — no -X main.X=... injection — so every locally-built binary (make build, go install, go install @latest) shipped with the package-level defaults from cmd/nodeup/main.go: 17-26: version=dev, commit=none, date=unknown. nodeup version then printed those literals on every local build, defeating the install-verification flow documented in docs/installation.md#verifying ("Should print a version, git commit, build date, and Go runtime info") and undermining the bug-report triage instructions in CONTRIBUTING.md that ask reporters to paste nodeup version output — a locally-built binary was indistinguishable from any other local build, so triage couldn't tell if the bug reproed on the latest commit or on a stale checkout. Fix: capture three Makefile vars at parse time and feed them into a single LDFLAGS variable used by both `build` and `install`: - VERSION from `git describe --tags --always --dirty` (closest semver tag, or short SHA + -dirty; falls back to `dev` if git is unavailable, e.g. snapshot tarball builds) - COMMIT from `git rev-parse --short HEAD` (falls back to `none`) - DATE from `date -u +%Y-%m-%dT%H:%M:%SZ` (RFC3339 UTC, matches .goreleaser.yaml:37's {{.CommitDate}} shape) Each shell call is wrapped with `|| echo <fallback>` so a build without .git/ doesn't crash. The combined LDFLAGS string is "-s -w -X main.version=$(VERSION) -X main.commit=$(COMMIT) -X main.date=$(DATE)" — same shape that goreleaser releases use, so a local build is indistinguishable from a release build via `nodeup version`. internal/cli/version_test.go: 5 new tests pin the exact output shape (line-by-line format, multi-line output, go1.X.Y runtime pattern, <goos>/<goarch> platform pattern, --check flag is a no-op not an error) so a future refactor can't silently drop a field. Brings internal/cli coverage from 29.2% to 31.1%. CHANGELOG: ### Fixed entry under [Unreleased]. Co-Authored-By: puku-ai-2.8 <noreply@puku.sh>

Commits

Commits on Jul 3, 2026

fix(ci): inject version/commit/date ldflags in make build and install