docs: fix link to page-constructor sandbox - #341
Merged
Conversation
✅ Documentation buildRevision built successfully Build logsWarnings (2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandbox link on the Page constructor page pointed to the
Editor/Mainstory in the main page-constructor Storybook. That story disappeared from the deployed Storybook after gravity-ui/page-constructor#1426 renamedEditor.stories.tsxtoEditor.tsx(the file no longer matches the stories glob), so the link opens a "story not found" page.Point to the Storybook preview of gravity-ui/page-constructor#1116 instead, where the same
Editor/Mainstory is still built and works. Editor 2.0 in that preview is not usable yet (its preview iframe is hardcoded tolocalhost:3000), so the old editor is the only working sandbox for now.Changed in both
ruandenversions ofproject/page-constructor.md.Superseded by #342, which points the link to the Diplodoc playground instead of a per-PR preview.