Experimental/fontawesome css unicode fix#540
Open
tagliala wants to merge 3 commits intofontawesome-cssfrom
Open
Experimental/fontawesome css unicode fix#540tagliala wants to merge 3 commits intofontawesome-cssfrom
tagliala wants to merge 3 commits intofontawesome-cssfrom
Conversation
tagliala
force-pushed
the
experimental/fontawesome-css-unicode-fix
branch
from
2876826 to
f6603e7
Compare
7 tasks
tagliala
force-pushed
the
fontawesome-css
branch
from
bffd1ae to
e3f11d0
Compare
tagliala
force-pushed
the
experimental/fontawesome-css-unicode-fix
branch
2 times, most recently
from
020c621 to
8366f16
Compare
tagliala
force-pushed
the
fontawesome-css
branch
from
e3f11d0 to
930729b
Compare
tagliala
force-pushed
the
experimental/fontawesome-css-unicode-fix
branch
from
8366f16 to
a58cf89
Compare
Fix to `_functions.scss` is trivial As per `_variables.scss`, a “find and replace in selection by regexp” functionality may be used. 1. Select lines containing variables 2. Find `: \\(.+);` and replace with `: "$1";` Note: regexp replacement syntax may change according to the editor. Our goal is to turn `$fa-var-0: \30;` into `$fa-var-0: "30";`
tagliala
force-pushed
the
experimental/fontawesome-css-unicode-fix
branch
from
a58cf89 to
5846641
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps are described in individual commits
Ref: FortAwesome/Font-Awesome#18775