Create tests to actually compare generated map_item functions#83
Draft
dale-wahl wants to merge 22 commits into
Draft
Create tests to actually compare generated map_item functions#83dale-wahl wants to merge 22 commits into
map_item functions#83dale-wahl wants to merge 22 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Fixture Management:
README.mdfortests/fixtures/explaining the layout and privacy considerations for real captured data used inmap_itemtests..gitignoreintests/fixtures/to ensure only intended files are tracked, protecting sensitive data.4CAT Integration Support:
.env.exampleintests/as a template for configuring 4CAT API access, supporting map_item comparison tests.MissingMappedFieldinjs/lib.jswith atoJSONmethod to produce 4CAT-compatible serialization for missing fields.Actual tests
Under development! Vision: use the "fixtures" (actual NDJSON Zeeschuimer output) -> run though the new
map_itemfunction for a given module -> compare that output to 4CAT's actualmap_itemoutput (via a new API endpoint).If this work, we should be able to pull a new automated PR and use the test to run on any collected live data. The tests should help us find any bugs in the new
map_itemand thus be able to verify this crazy process works.Current state
The testing kind of works, yay. And I made a translation errors doc that I want to feed into the prompt to try to avoid the same errors again.
The testing environment is... not great and I would like to clean it up a bit. JS testing is very new to me so I have been learning a lot here. (Currently a lot of trial and error...)