Add Distance/Skybox blocks and fix jump precision#176
Conversation
- Implemented `get_distance_between` block to calculate distance between two meshes. - Implemented `set_skybox_url` block to allow custom environment backgrounds via URL. - Fixed a bug in `playerJump` where the ground detection ray was too long (reduced offset from 0.8 to 0.1). - Added `tests/jump.spec.js` to verify jump logic and prevent regressions. - Updated `BabylonSceneManager` with `getDistance` and `setSkyboxUrl` methods. - Added JavaScript generators for the new blocks. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR introduces two new features and one bug fix to the 3D engine:
playerJumpdetection logic. Previously, the detection ray was too long, allowing players to jump while floating in the air. The raycast offset was reduced to0.1for tighter, more accurate ground detection.Automated tests were added in
tests/jump.spec.jsto ensure the jump logic remains precise. Frontend verification was performed to confirm the new blocks are correctly integrated into the Blockly toolbox.PR created automatically by Jules for task 2718755351492916509 started by @brettfxio