Enhance Physics API and Fix Loading Screen Stacking#175
Conversation
- Add setLinearVelocity and setAngularVelocity methods to BabylonSceneManager. - Add corresponding Blockly blocks and generators for velocity control. - Implement clearCollisionCache to allow re-triggering collisions. - Fix bug where multiple loading screens could stack in the DOM. - Add Playwright test to verify the loading screen fix. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR introduces several enhancements to the physics API and fixes a UX bug related to the loading screen.
Physics Enhancements
setLinearVelocityandsetAngularVelocityto theBabylonSceneManager, allowing developers to directly set the velocity of physics-enabled objects. Corresponding Blockly blocks have been added to the 'Game' category.clearCollisionCachemethod and block. This is useful for scenarios where a collision needs to be detected multiple times between the same pair of objects (e.g., a repeating bounce effect).UX Bug Fixes
displayLoadingUI(either from code or rapid user interaction) would result in multipledivelements being appended to the DOM. A guard check now ensures only one loading screen exists at a time.Testing
tests/loading_screen.spec.jsto specifically verify the loading screen fix.PR created automatically by Jules for task 13312066207241550192 started by @brettfxio