Skip to content

Enhance STEM blocks and VRM animation retargeting#172

Open
brettfxio wants to merge 1 commit into
mainfrom
feature/stem-animation-enhancements-10079560620570452349
Open

Enhance STEM blocks and VRM animation retargeting#172
brettfxio wants to merge 1 commit into
mainfrom
feature/stem-animation-enhancements-10079560620570452349

Conversation

@brettfxio

Copy link
Copy Markdown
Contributor

This PR enhances the engine's STEM capabilities and animation workflow.

Key changes:

  1. STEM Enhancements:
    • Renamed the "Utils" category to "Math" to align with educational standards.
    • Added a distance between [obj1] and [obj2] block for spatial calculations.
    • Added look at [target] and move towards [target] at speed [v] blocks. These methods use setAbsolutePosition and getAbsolutePosition to ensure correct behavior within complex 3D hierarchies.
  2. Animation Improvements:
    • Added an apply mixamo animation [anim] to [model] block. This provides automatic bone mapping between Mixamo's skeletal structure and the VRM standard.
    • Implemented a caching mechanism on the mesh object to ensure retargeting logic only runs once per animation, even if called inside a game loop.
  3. Verification:
    • New tests in tests/stem_blocks.spec.js verify the logic for distance, orientation, and movement.
    • Visual verification confirmed the toolbox updates and block availability.

PR created automatically by Jules for task 10079560620570452349 started by @brettfxio

- Rename 'Utils' toolbox category to 'Math' and update color to green (#59C059).
- Implement `getDistance`, `lookAt`, and `moveTowards` in `BabylonSceneManager` using world-space coordinates.
- Add `applyMixamoAnimation` with bone mapping for VRM models and caching to prevent redundant computations.
- Add corresponding Blockly blocks and generators for all new methods.
- Add Playwright tests in `tests/stem_blocks.spec.js` for mathematical verification.

Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant