Fix scoped context and conflicting properties#263
Open
mielvds wants to merge 5 commits into
Open
Conversation
|
The tests correspond to the initial issue 👍 Thanks for your work ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #204 and two related tests in the test-suite:
https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#tc037
https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#tc038
The issue was that
@nestkeys were delayed for later expansion before their property-scoped context was applied. This fix first gets the scoped@contextfrom the@nestterm and stores this property-scoped context with the key. The delayed nested object expansion then later uses that property-scoped context, so p2 expands to http://example.org/ns#P2 instead of falling back to outer@vocab.