allow non-string template params via lightweight inspect()#3
Merged
Conversation
Params of any type (numbers, objects, arrays, etc.) are now stringified using a built-in inspect() utility. String params remain unquoted for backward compatibility. Includes bug fixes: Invalid Date handling, depth-independent rendering of Error/RegExp/Date, and correct shared (non-circular) reference handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Wrap inspect in try-catch so getters, proxies, or overridden prototype methods that throw never crash error construction - Truncate large collections (arrays, objects, Maps, Sets) at 50 items - Truncate long nested strings at 200 chars - Use Map/Set forEach instead of spread to avoid iterator-based attacks - Add TypedArray support (renders as e.g. Uint8Array([ 1, 2, 3 ])) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspect()utility to stringify non-string template parameters (numbers, objects, arrays, dates, maps, sets, etc.)stringtounknownTest plan
tsdtype tests for non-string param valuesnpm testpasses (both runtime and type tests)🤖 Generated with Claude Code