Skip to content

feat: Throw error when attempting to remove self#1269

Merged
RangerMauve merged 2 commits into
mainfrom
feat/error-on-remove-self
May 19, 2026
Merged

feat: Throw error when attempting to remove self#1269
RangerMauve merged 2 commits into
mainfrom
feat/error-on-remove-self

Conversation

@RangerMauve

Copy link
Copy Markdown
Contributor

Closes #1167

@RangerMauve RangerMauve requested a review from achou11 May 18, 2026 21:42

@achou11 achou11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment that may result in changes, but otherwise LGTM!

Comment thread src/member-api.js Outdated
@RangerMauve RangerMauve enabled auto-merge (squash) May 19, 2026 14:44
@RangerMauve RangerMauve merged commit 8b21cf2 into main May 19, 2026
11 checks passed
@RangerMauve RangerMauve deleted the feat/error-on-remove-self branch May 19, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MemberApi.remove() should error when attempting to remove yourself?

2 participants