fix(workflow-audit): find the previous successful run without the stale status filter - #920
Merged
Merged
Conversation
…us filter The runs listing filtered by status=success returned 2026-09-03 as the newest success on three nights while the unfiltered listing showed daily successes, so #811, #880, and #915 each re-listed about 24 commits earlier audits had already covered. Select the newest success from the unfiltered listing instead; the bound is still that run's server-set created_at.
Deploying mouseterm with
|
| Latest commit: |
c66fa14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://821d7836.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-workflow-audit-since-370.mouseterm.pages.dev |
nedtwigg
requested a deployment
to
hosted-preview
October 2, 2026 15:37 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workflow-audithas opened three issues (#811 on 09-28, #880 on 10-01, #915 today) that each re-list 23–24 commits earlier audits had already covered. All three report the same lower bound,2026-09-03T12:03:48Z. The bound comes fromruns?status=success&per_page=1, and that filtered listing is stale: right now it reportstotal_count: 31with 2026-09-03 as the newest success. The unfiltered listing for the same workflow has a success every day through today (2026-10-02T13:48:12Z).This PR selects the newest
conclusion == "success"run from the unfiltered listing, which is newest first, so the--sincebound becomes the previous successful run's server-setcreated_atagain. That is the contractdocs/specs/security-ci.md→ "Automated Maintainer (tend)" audits ("must stay the previous successful run's server-setcreated_at"). The in-progress run has no conclusion yet, so it can't select itself. If no success exists, the empty-string fallback to 25 hours still applies.Verification: I ran the new snippet under
set -euo pipefailagainst this repo, and it returned2026-10-02T13:48:12Z. The empty-input case yields an emptySINCE, and the YAML parses. The first scheduled run after merge should report a bound of about one day.Refs #915. Once this merges, the 24 commits #915 lists still need accounting for, or the issue can be closed as a stale-bound duplicate of #880.