Fix comments left stale by the Hosted, alert-pause, and Surface-move work - #909
Merged
Merged
Conversation
…work Point the comments at the code and specs they now describe: the VS Code engines floor, a removed module header, the deferral timer's role after the pause rework, managed-voice playback, the relay heartbeat's owning spec, and lint-kit's consumers. Reattach WallHandle's doc comment, which PreparedSurfaceMove had split from its interface.
Deploying mouseterm with
|
| Latest commit: |
f815d37
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6b1a7aa.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-stale-comments-after-hos.mouseterm.pages.dev |
dormouse-bot
requested a deployment
to
hosted-preview
October 2, 2026 12:47 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only cleanup in files none of the open PRs touch. Each of these comments described code or specs that this week's merges (#867–#872, #885–#888) changed underneath them. No behavior changes.
vscode-ext/src/burrow.ts:createRelaySocketstill citedengines.vscode^1.85.0/ Node 18. The floor is^1.92.0(Node 20.14, perdocs/specs/vscode.rationale.md), and thewsfallback is still needed for the same reason.initBurrowpointed at "the module header", which is now a one-line pointer, so it now namesdocs/specs/vscode.md→ "Burrow: a service in the extension host" directly.lib/src/lib/alert-manager.ts:scheduleDeferredNotificationsaid the timer matters "for output that never goes quiet". After the pause rework, output that never goes quiet just re-arms the timer. The timer is what releases a deferral after output that never confirmed busy, sinceQuiesceDetectorsettles only fromBUSY. It also releases one after a command boundary, and publishes a pause's end.lib/src/lib/alert-delivery-scheduler.ts,lib/src/lib/alert-delivery.ts: speech can now be host-fetched managed-voice audio as well aswindow.speechSynthesis, matching the Authority row indocs/specs/alert.md.lib/src/remote/client/pocket-client.ts: the heartbeat comment citedpocket-app.md, which says nothing about heartbeats. It now citesdocs/specs/relay.md→ "Routing", aslib/src/remote/ws.tsdoes.lib/src/components/wall/wall-handles.ts:PreparedSurfaceMovewas inserted betweenWallHandleand its doc comment. Its declaration now sits above that comment.lib/src/stories/PhoneFrame.tsx,scripts/lint-kit.mjs: the consumer lists had grown stale (the frame is also used by the one-time and pairing stories, and lint-kit by every lint). They now describe the consumers instead of listing them. ThenormalizeEol"shared with the self-tests" claim was dropped, since no self-test imports it.No regression test, because only comments change. I couldn't run the suite locally: this runner has no network access to install dependencies, so CI is the check.
argos/storybook-webkitreports one changed screenshot waiting for a decision. A comment-only diff can't move a screenshot, and #899, which changes only Windows test fixtures, shows the same single WebKit change. Every other check is green.