Skip to content

Fix comments left stale by the Hosted, alert-pause, and Surface-move work - #909

Merged
nedtwigg merged 1 commit into
mainfrom
fix/stale-comments-after-hosted-and-alert-work
Oct 2, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
fix/stale-comments-after-hosted-and-alert-work

Conversation

@dormouse-bot

@dormouse-bot dormouse-bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Comment-only cleanup in files none of the open PRs touch. Each of these comments described code or specs that this week's merges (#867–#872, #885–#888) changed underneath them. No behavior changes.

  • vscode-ext/src/burrow.ts: createRelaySocket still cited engines.vscode ^1.85.0 / Node 18. The floor is ^1.92.0 (Node 20.14, per docs/specs/vscode.rationale.md), and the ws fallback is still needed for the same reason. initBurrow pointed at "the module header", which is now a one-line pointer, so it now names docs/specs/vscode.md → "Burrow: a service in the extension host" directly.
  • lib/src/lib/alert-manager.ts: scheduleDeferredNotification said the timer matters "for output that never goes quiet". After the pause rework, output that never goes quiet just re-arms the timer. The timer is what releases a deferral after output that never confirmed busy, since QuiesceDetector settles only from BUSY. It also releases one after a command boundary, and publishes a pause's end.
  • lib/src/lib/alert-delivery-scheduler.ts, lib/src/lib/alert-delivery.ts: speech can now be host-fetched managed-voice audio as well as window.speechSynthesis, matching the Authority row in docs/specs/alert.md.
  • lib/src/remote/client/pocket-client.ts: the heartbeat comment cited pocket-app.md, which says nothing about heartbeats. It now cites docs/specs/relay.md → "Routing", as lib/src/remote/ws.ts does.
  • lib/src/components/wall/wall-handles.ts: PreparedSurfaceMove was inserted between WallHandle and its doc comment. Its declaration now sits above that comment.
  • lib/src/stories/PhoneFrame.tsx, scripts/lint-kit.mjs: the consumer lists had grown stale (the frame is also used by the one-time and pairing stories, and lint-kit by every lint). They now describe the consumers instead of listing them. The normalizeEol "shared with the self-tests" claim was dropped, since no self-test imports it.

No regression test, because only comments change. I couldn't run the suite locally: this runner has no network access to install dependencies, so CI is the check.

argos/storybook-webkit reports one changed screenshot waiting for a decision. A comment-only diff can't move a screenshot, and #899, which changes only Windows test fixtures, shows the same single WebKit change. Every other check is green.

…work

Point the comments at the code and specs they now describe: the VS Code engines floor, a removed module header, the deferral timer's role after the pause rework, managed-voice playback, the relay heartbeat's owning spec, and lint-kit's consumers. Reattach WallHandle's doc comment, which PreparedSurfaceMove had split from its interface.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: f815d37
Status: ✅  Deploy successful!
Preview URL: https://d6b1a7aa.mouseterm.pages.dev
Branch Preview URL: https://fix-stale-comments-after-hos.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit 619a58f into main Oct 2, 2026
14 of 15 checks passed

This branch is waiting to be deployed

1 waiting deployment
hosted-preview — f815d379 Waiting Oct 2, 2026 by dormouse-bot via deploy #735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants