Skip to content

Trim dor-cli.md back under its spec word budget #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dormouse-bot wants to merge 1 commit into from
Closed

Trim dor-cli.md back under its spec word budget #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions docs/specs/dor-cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ does nothing and **exits 0** (rationale). **Dormouse-launched terminals must
rely on injected env, never on a globally installed Node**; each launcher's
`PATH`-`node` fallback is for developer/manual use.

**Both launchers must exit with the CLI's own status**, which `dor await` and every
script branching on `dor` depend on. `dor/test/launcher.test.mjs` pins it, running
`dor.cmd` on the Windows leg of CI's `standalone-platform-check`.
**Both launchers must exit with the CLI's own status**, which scripts (and
`dor await` callers) branch on. `dor/test/launcher.test.mjs` pins it, including
`dor.cmd` on CI's Windows `standalone-platform-check` leg.

Public PTY env:

Expand Down Expand Up @@ -528,8 +528,8 @@ absolute URL:
the dev server that terminal owns; and
- a schemeless **`host:port`** — defaulted to `http://` (`box.ts.net:3000` →
`http://box.ts.net:3000/`), including the bare **`:port`** localhost shorthand
(`:5173` → `http://localhost:5173/`). Purely a string rewrite, so it needs no
host and works outside Dormouse.
(`:5173` → `http://localhost:5173/`). A pure string rewrite: it needs no host
and works outside Dormouse.

**The explicit port, never the hostname, is the signal for the `http` default**
(rationale). An explicit scheme is always honored — a public HTTPS service on a
Expand Down Expand Up @@ -738,8 +738,7 @@ Source of truth: `toolCommand` in `dor/src/commands/tool.ts`; `openCommand` in `
there, so `dor list --all` would have to aggregate at the extension host
rather than in a per-webview control handler; until it does, VS Code refuses
the Workspace-spanning requests ([dor workspace](#dor-workspace)).
- **Additional `dor list` filters** — activity/state filters are deliberately
deferred: `--running` as shorthand for `--activity running`, full `--activity
unknown|prompt|editing|running|finished`, and possible alert filters such as
`--alert` / `--todo`. Add only once a story needs them, each with
- **Additional `dor list` filters** — `--running` as shorthand for `--activity
running`, full `--activity unknown|prompt|editing|running|finished`, and alert
filters (`--alert`, `--todo`). Add only once a story needs them, each with
snapshot-tested help.
Loading