Lock down the three flaky visual snapshots - #770
Merged
Merged
Conversation
- RemoteControlSection: freeze `Date.now` for the file and let the stub mint the setup code under it; the QR encodes its expiry, so a real clock drew a new code every run. - Kill confirmation: `cfg.killConfirm.char` pins the letter, set under visual snapshots. - Wall TerminalContext: hold the capture until the helper's autorun has finished rather than whichever of waiting/running it had reached. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
nedtwigg
marked this pull request as ready for review
September 23, 2026 18:52
Deploying mouseterm with
|
| Latest commit: |
fd51559
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fc43dfaa.mouseterm.pages.dev |
| Branch Preview URL: | https://lock-flaky-snapshots.mouseterm.pages.dev |
dormouse-bot
approved these changes
Sep 23, 2026
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
nedtwigg
requested a deployment
to
hosted-preview
September 23, 2026 19:09 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Argos runs (#765) showed three stories rendering differently on every run. The cause was in the stories, not in Argos, so Chromatic was capturing the same instability.
expiresAt = Date.now() + TTL, so each run drew a different QR.Date.nowin its metabeforeEach. The story drops its import-timesetupQrResult()and lets the stub mint the code at request time, under the frozen clock.randomKillChar()usesMath.random().cfg.killConfirm.charpins the letter; the preview's visual-snapshot block sets it toq.What's left is ±1 colour-level antialiasing on rounded focus-ring corners in SettingsDialog, which is below Argos's diff threshold.
Test plan
KillConfirm.test.tsfails when thecfg.killConfirm.char ??is deleted.pnpm --filter dormouse-lib test,spec-lint🤖 Generated with Claude Code