feat: ✨ add OCO_EMOJI_POSITION_BEFORE_DESCRIPTION - #288
ThomasSanson wants to merge 5 commits into
Conversation
…ION config key and implement its usage in prompts The new configuration key OCO_EMOJI_POSITION_BEFORE_DESCRIPTION has been added to allow users to specify the position of the GitMoji in the commit message. This provides flexibility for users who may have different preferences for the placement of the GitMoji. The prompts have been updated to reflect this new configuration option and will now generate commit messages according to the user's preference.
|
Stale pull request message |
# Conflicts: # out/cli.cjs # out/github-action.cjs # package-lock.json
… commit messages This update provides users with the ability to customize the placement of GitMoji in their commit messages. It includes examples and command line instructions for setting the GitMoji position either before the description or at the start of the commit message.
|
@di-sukharev, may I kindly request that you assume responsibility for this pull request ? Indeed, it appears that each time you approve another pull request, it leads to git conflicts on this one. To prevent such occurrences, it seems prudent for you to manage this task, thereby facilitating a more autonomous and direct resolution of the issue. |
|
|
Will manage when i have time ;) thank you
|
There was a problem hiding this comment.
Configurable GitMoji placement remains a reasonable feature, but this PR is based on the old prompt architecture, conflicts with master, and includes generated out files. Please port the idea onto master, do not commit generated bundles manually, and add prompt/unit tests for both positions and the OCO_EMOJI/OCO_DESCRIPTION combinations.
Dear @di-sukharev, I hope this message finds you well. Revisiting this issue certainly brought a smile to my face (in the most respectful sense). Indeed, two years on, the codebase has evolved considerably, and I would like to commend and thank you once again for your efforts. I shall endeavour to free up some time to prepare and submit an update. Kind regards |
|
Thanks for coming back to this. To save you the rebase work, I took the implementation over and rewrote it against the current master. It landed in c56ec3c with config/env/help support, documentation, Conventional Commit and commitlint prompt handling, |
|
One more follow-up for completeness: PR #585 adds regression coverage for the commitlint prompt path, omit-scope formatting, localized full-width colon separators, and the no-separator fallback. It has now been merged into master after all checks passed, keeping the implementation easy to maintain across all supported prompt shapes. |
2 participants
Hello @di-sukharev,
I have submitted this pull request wherein I have made several amendments to your opencommit project.
I have introduced a new configuration key
OCO_EMOJI_POSITION_BEFORE_DESCRIPTIONthat allows users to customise the position of the emoji within the commit message. This provides users with greater flexibility in formatting their commit messages.I have updated the instructions within
generateCommitMessageFromGitDiff.tsto reflect this new option.I have also updated the
README.mdfile to include instructions on how to utilise theOCO_EMOJI_POSITION_BEFORE_DESCRIPTIONconfiguration. This configuration allows users to determine where the GitMoji should be placed within the commit message.I have updated the assistant to accommodate the new
OCO_EMOJI_POSITION_BEFORE_DESCRIPTIONconfiguration. The assistant now generates commit messages based on the emoji position specified by the user.Lastly, I have updated the package version from 2.4.2 to 3.0.4 to reflect these new modifications and improvements.
I would like to emphasise that I have tested these modifications locally and everything appears to be functioning as expected.
The results are visible in the commit.
However, I would like to draw your attention to the fact that the documentation for contributing to the project is somewhat sparse. This could make access to contribution more challenging for new contributors. I believe it would be beneficial to enhance this aspect to facilitate community contribution.
Thank you for your time and consideration. I eagerly await your feedback on my pull request.
Close #219