Conversation
Lars-
commented
Mar 15, 2023
Lars-
commented
- add skipCommitMessageCheck config key
- add support for skipCommitMessageCheck config key to skip commit message check if set to true
feat(prepare-commit-msg-hook.ts): add support for skipCommitMessageCheck config key to skip commit message check if set to true
| description = 'description', | ||
| emoji = 'emoji' | ||
| emoji = 'emoji', | ||
| skipCommitMessageCheck = 'skipCommitMessageCheck' |
There was a problem hiding this comment.
lets rename it to skipCommitMsgHookSourceCheck?
There was a problem hiding this comment.
awesome @Lars- thanks! could you change base branch to dev instead of master pls <3
There was a problem hiding this comment.
@Lars- there is a conflict, could you solve pls and let's merge it!
There was a problem hiding this comment.
The issue wasn't there when I sent the PR, so you may change it
…okSourceCheck refactor(prepare-commit-msg-hook.ts): update reference to skipCommitMessageCheck to skipCommitMsgHookSourceCheck update variable name
…n hook Added explanation to readme
|
Also added a part to readme.md |
|
Stale pull request message |
|
please pull latest |
|
I don’t have the time for that, but you should be able to change the code in the PR yourself. |
|
Am I missing this functionality in the current release or do I need to fork this repo? @di-sukharev |
There was a problem hiding this comment.
An option to disable the prepare-commit-msg hook may be useful, but this three-year-old implementation conflicts with the current hook flow and OCO_HOOK_AUTO_UNCOMMENT. Please submit a fresh PR from master with clearly defined option semantics, documentation, and end-to-end coverage. The current branch cannot be merged.
4 participants
