Repository navigation
Sonar: leave binary files out of the scan, and clear master's open issues - #517
Merged
Merged
Conversation
sonar.sources=. made Sonar read every image, font, sound and save as text and warn that it is not UTF-8, once per file. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…escape calc-worker.ts's getSave/putSave were async with nothing to await (S7503); speedrun-page.ts imported ./editions twice (S3863). text.ts compared against a literal replacement character, which the scan read as an invalid byte. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dhobi
changed the title
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sonar.sources=.made Sonar read every PNG, JPG, GIF, WebP, AVIF, font, sound,.stgand.tisave as source text. The scan logged "Invalid character encountered … for encoding UTF-8" for 13 of them (for example in the SonarQube Cloud job on #516).sonar.exclusions, and to a newsonar.test.exclusionsfor the fixtures undertests/. None of them were code.engine/src/df/text.ts:106compared against a literal U+FFFD; it is now written as"\\uFFFD".calc-worker.ts:getSave/putSavewereasyncwith nothing to await (S7503); they now return a resolved promise.speedrun-page.ts: imported./editionstwice (S3863).🤖 Generated with Claude Code