Skip to content

Captions: "prefer port captions" picks our transcript over the game's text (#505) - #514

Merged
dhobi merged 1 commit into
masterfrom
captions-prefer-port
Oct 6, 2026
Merged

dhobi merged 1 commit into
masterfrom
captions-prefer-port

Conversation

@dhobi

@dhobi dhobi commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Fixes #505.

The pocket watch in bedcards.mov plays the boss's lines under sound names that point at NARRATE.PUP's lines 01–07. That file holds an older draft of the speech ("The Kaiser's mobilizing as we speak! It's war!"). The English recording follows a rewritten, quieter script, and so do the Dutch, Japanese and Russian ones, since Dutch and Japanese reuse the English audio. German and French recorded the old draft.

What changes

  • New checkbox, "prefer port captions", under Subtitles. It is remembered, and its label is in all six languages. When a line has both an original caption (text from the game's files) and a port caption (our transcript), it shows the port caption; otherwise it shows whichever exists. The two are never shown together.
    • The engine side is GameSession.preferPortCaptions, read in captionMovieSound.
  • The watch gets port captions in en, de, fr, ru and ja. These are Whisper drafts, not yet checked by ear. ja gets the English text with the speaker shown as 上司, since it plays the English recording.
  • The four kinds of on-screen text are named at the top of taoot/src/captions.ts: subtitles, original captions, port captions and burnt-in captions.
  • Japanese burnt-in captions are part of the film's pictures and always show; the checkboxes behave the same over them.
Checkboxes Shown
none subtitles (+ burnt-in in ja)
every line that is heard + original captions; a port caption where the game has no text
+ prefer port captions + port captions where they exist, otherwise original captions

Checks

  • taoot/tests/auto/regression.ts:
    • By default the watch shows "It's war!".
    • With the setting on, it shows "Boss: Especially now.".
    • A line with no transcript (zeit.mov) still comes from the game.
    • The test that Dutch and Japanese reuse the English recordings now lists bedcards.mov as a known exception: the audio clips are identical, the pictures differ.
  • The caption and locale suites pass; tsc is clean.

🤖 Generated with Claude Code

… text (#505)

The watch in bedcards.mov plays the boss's lines named after NARRATE.PUP's
01-07, which hold an older draft ("It's war!") than English, Dutch,
Japanese and Russian recorded. A new checkbox under Subtitles lets a line
with both an original caption (game files) and a port caption (our
transcript) show the port caption; off, the game's text stays. The watch
gets port captions in en, de, fr, ru and ja (Whisper drafts; ja plays the
English recording). The four kinds of on-screen text are named in
taoot/src/captions.ts.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@dhobi
dhobi merged commit 9224194 into master Oct 6, 2026
4 checks passed
@dhobi
dhobi deleted the captions-prefer-port branch October 6, 2026 21:53
@dhobi dhobi mentioned this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Titanic] Watch memory caption issues (Bug in bedsit1 — Scene1 / View31)

1 participant