Repository navigation
Captions: "prefer port captions" picks our transcript over the game's text (#505) - #514
Merged
Merged
Conversation
… text (#505) The watch in bedcards.mov plays the boss's lines named after NARRATE.PUP's 01-07, which hold an older draft ("It's war!") than English, Dutch, Japanese and Russian recorded. A new checkbox under Subtitles lets a line with both an original caption (game files) and a port caption (our transcript) show the port caption; off, the game's text stays. The watch gets port captions in en, de, fr, ru and ja (Whisper drafts; ja plays the English recording). The four kinds of on-screen text are named in taoot/src/captions.ts. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #505.
The pocket watch in
bedcards.movplays the boss's lines under sound names that point at NARRATE.PUP's lines 01–07. That file holds an older draft of the speech ("The Kaiser's mobilizing as we speak! It's war!"). The English recording follows a rewritten, quieter script, and so do the Dutch, Japanese and Russian ones, since Dutch and Japanese reuse the English audio. German and French recorded the old draft.What changes
GameSession.preferPortCaptions, read incaptionMovieSound.en,de,fr,ruandja. These are Whisper drafts, not yet checked by ear.jagets the English text with the speaker shown as 上司, since it plays the English recording.taoot/src/captions.ts: subtitles, original captions, port captions and burnt-in captions.Checks
taoot/tests/auto/regression.ts:bedcards.movas a known exception: the audio clips are identical, the pictures differ.tscis clean.🤖 Generated with Claude Code