fix: correct previous monthly period for December [DHIS2-21584]#96
Draft
eirikhaugstulen wants to merge 2 commits into
Draft
fix: correct previous monthly period for December [DHIS2-21584]#96eirikhaugstulen wants to merge 2 commits into
eirikhaugstulen wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 90.87% 90.88%
=======================================
Files 57 57
Lines 1249 1250 +1
Branches 352 353 +1
=======================================
+ Hits 1135 1136 +1
Misses 112 112
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eirikhaugstulen
force-pushed
the
eh/fix-december-previous-monthly-period
branch
from
May 30, 2026 14:36
1d0bfd1 to
9465c51
Compare
eirikhaugstulen
changed the base branch from
fix/weekly-period-display-name
to
main
May 30, 2026 14:37
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes DHIS2-21584 by preventing getAdjacentFixedPeriods from returning the current monthly period when stepping backwards from December.
Root Cause
Monthly backward traversal used the period start date year and a slice boundary based on the first later period. For December, there is no later monthly period in the generated year, so the boundary calculation could include the current December period instead of ending before it.
Changes
Validation