fix: exclude current year-end weekly period [DHIS2-21585]#95
Draft
eirikhaugstulen wants to merge 2 commits into
Draft
fix: exclude current year-end weekly period [DHIS2-21585]#95eirikhaugstulen wants to merge 2 commits into
eirikhaugstulen wants to merge 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.02%
==========================================
Files 57 57
Lines 1249 1252 +3
Branches 352 353 +1
==========================================
+ Hits 1135 1138 +3
Misses 112 112
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes DHIS2-21585 by preventing getAdjacentFixedPeriods from returning the current weekly period when stepping backwards from the final week of a year.
Root Cause
The weekly backward traversal searched for the first period with a start date after the current period. When the current period was the last generated week in the year, no later start date existed, so the slice boundary fell at the end of the year and included the current period again.
Changes
Validation