Skip to content

Fixed post dependency definitions#2

Open
stanstrup wants to merge 3 commits into
dgrapov:masterfrom
stanstrup:master
Open

Fixed post dependency definitions#2
stanstrup wants to merge 3 commits into
dgrapov:masterfrom
stanstrup:master

Conversation

@stanstrup

Copy link
Copy Markdown

The functions 'translate.index' and 'IDEOMgetR' seem not to be defined anywhere and I don't know if they are from some other package.

CTSgetR has different parameters in the code and man page.
There are a number of other build check errors still left.

@dgrapov

dgrapov commented May 21, 2016

Copy link
Copy Markdown
Owner

I've pushed a recently tested version. See the branch simple.
It seems to work?

Thanks!
-Dmitry

@dgrapov

dgrapov commented May 22, 2016

Copy link
Copy Markdown
Owner

Hi,

Thank you for the pull request, can you please take a look at the simple branch to see if your original issue is fixed?

I took some more time and rewrote the package using httr which greatly simplified everything. I am using GET; where did you need a POST?

-Dmitry

@stanstrup

Copy link
Copy Markdown
Author

Hi. I checked it now. Dependencies are still not defined in the DESCRIPTION file.
You should probably add the used packages as "imports".

The check fails with this error so I don't know if there are more problems:

checking package dependencies ... ERROR
Namespace dependencies not required: 'httr' 'jsonlite'

@dgrapov

dgrapov commented May 26, 2016

Copy link
Copy Markdown
Owner

Ok, now check is passing.
If you need any of the older functionality feel free to add; I will accept pulls 😄 .

Thanks.

-Dmitry

@dgrapov

dgrapov commented May 26, 2016

Copy link
Copy Markdown
Owner

Note one of the test is failing, but I also noticed CTS has variability for failures, so I am ignoring this. Could remove test if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants