chore: Inline BUILD.bazel dependency vars under governance-team#10257
Merged
Conversation
Inline module-level DEPENDENCIES, MACRO_DEPENDENCIES, etc variables into their consuming targets. Where inlining made a wasm32-unknown-unknown select redundant (test-only targets or canister-only targets), the select is also dropped.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors a set of Bazel BUILD.bazel files (primarily under NNS/SNS/registry/nervous_system) by inlining previously shared module-level dependency variables (e.g., DEPENDENCIES, DEV_DEPENDENCIES, MACRO_DEPENDENCIES, ALIASES) directly into the targets that consume them. In a few places it also removes wasm32-unknown-unknown select() blocks that are now redundant due to the dependency lists being used only by host-only test targets.
Changes:
- Inlined
proc_macro_depsanddepslists into individualrust_*targets; removed now-unused module-level dependency variables. - Removed
ALIASES = {}and correspondingaliases = ALIASESassignments where they were effectively no-ops. - Simplified some
select({ wasm32: ..., default: ... })blocks where the selection no longer affects any wasm-built targets.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rs/sns/integration_tests/BUILD.bazel | Inline macro deps into library/test targets; remove unused aliases/vars. |
| rs/sns/governance/BUILD.bazel | Inline proc-macro deps into each target; remove unused aliases/vars. |
| rs/registry/nns_data_provider/BUILD.bazel | Inline deps and proc-macro deps into library/tests; drop module-level lists. |
| rs/registry/canister/BUILD.bazel | Inline large deps/proc-macro deps/env/data lists into each target; remove helper vars. |
| rs/nns/test_utils/BUILD.bazel | Inline deps and proc-macro deps into library/tests; remove module-level lists. |
| rs/nns/sns-wasm/BUILD.bazel | Inline proc-macro deps; simplify DEV deps (drop redundant wasm select). |
| rs/nns/integration_tests/BUILD.bazel | Simplify test-feature deps list and remove unused aliases/macro-dev deps. |
| rs/nns/handlers/root/impl/BUILD.bazel | Inline proc-macro deps; simplify DEV deps (drop redundant wasm select). |
| rs/nns/gtc/BUILD.bazel | Inline proc-macro deps; simplify DEV deps and macro deps selection. |
| rs/nns/governance/BUILD.bazel | Inline TLA proc-macro dep at call sites; remove aliases and macro-dev var. |
| rs/nervous_system/timer_task/BUILD.bazel | Inline deps/proc-macro deps; simplify test/canister dependency composition. |
| rs/nervous_system/neurons_fund/nfplot/BUILD.bazel | Inline binary deps list (remove module-level DEPENDENCIES). |
| rs/nervous_system/long_message/BUILD.bazel | Inline deps and simplify host/canister deps while preserving wasm select where needed. |
| rs/nervous_system/integration_tests/BUILD.bazel | Inline proc-macro deps; remove empty dev-deps var and simplify deps expressions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bjoernek
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline module-level DEPENDENCIES, MACRO_DEPENDENCIES, etc variables into their consuming targets. Where inlining made a wasm32-unknown-unknown select redundant (test-only targets or canister-only targets), the select is also dropped.