Skip to content

chore: Inline BUILD.bazel dependency vars under governance-team#10257

Merged
nmattia merged 1 commit into
masterfrom
nm-gov-inline
May 21, 2026
Merged

chore: Inline BUILD.bazel dependency vars under governance-team#10257
nmattia merged 1 commit into
masterfrom
nm-gov-inline

Conversation

@nmattia
Copy link
Copy Markdown
Contributor

@nmattia nmattia commented May 19, 2026

Inline module-level DEPENDENCIES, MACRO_DEPENDENCIES, etc variables into their consuming targets. Where inlining made a wasm32-unknown-unknown select redundant (test-only targets or canister-only targets), the select is also dropped.

Inline module-level DEPENDENCIES, MACRO_DEPENDENCIES, etc variables
into their consuming targets. Where inlining made a
wasm32-unknown-unknown select redundant (test-only targets or canister-only
targets), the select is also dropped.
@github-actions github-actions Bot added the chore label May 19, 2026
@nmattia nmattia marked this pull request as ready for review May 21, 2026 10:21
@nmattia nmattia requested a review from a team as a code owner May 21, 2026 10:21
@nmattia nmattia enabled auto-merge May 21, 2026 10:21
github-actions[bot]

This comment was marked as spam.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors a set of Bazel BUILD.bazel files (primarily under NNS/SNS/registry/nervous_system) by inlining previously shared module-level dependency variables (e.g., DEPENDENCIES, DEV_DEPENDENCIES, MACRO_DEPENDENCIES, ALIASES) directly into the targets that consume them. In a few places it also removes wasm32-unknown-unknown select() blocks that are now redundant due to the dependency lists being used only by host-only test targets.

Changes:

  • Inlined proc_macro_deps and deps lists into individual rust_* targets; removed now-unused module-level dependency variables.
  • Removed ALIASES = {} and corresponding aliases = ALIASES assignments where they were effectively no-ops.
  • Simplified some select({ wasm32: ..., default: ... }) blocks where the selection no longer affects any wasm-built targets.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rs/sns/integration_tests/BUILD.bazel Inline macro deps into library/test targets; remove unused aliases/vars.
rs/sns/governance/BUILD.bazel Inline proc-macro deps into each target; remove unused aliases/vars.
rs/registry/nns_data_provider/BUILD.bazel Inline deps and proc-macro deps into library/tests; drop module-level lists.
rs/registry/canister/BUILD.bazel Inline large deps/proc-macro deps/env/data lists into each target; remove helper vars.
rs/nns/test_utils/BUILD.bazel Inline deps and proc-macro deps into library/tests; remove module-level lists.
rs/nns/sns-wasm/BUILD.bazel Inline proc-macro deps; simplify DEV deps (drop redundant wasm select).
rs/nns/integration_tests/BUILD.bazel Simplify test-feature deps list and remove unused aliases/macro-dev deps.
rs/nns/handlers/root/impl/BUILD.bazel Inline proc-macro deps; simplify DEV deps (drop redundant wasm select).
rs/nns/gtc/BUILD.bazel Inline proc-macro deps; simplify DEV deps and macro deps selection.
rs/nns/governance/BUILD.bazel Inline TLA proc-macro dep at call sites; remove aliases and macro-dev var.
rs/nervous_system/timer_task/BUILD.bazel Inline deps/proc-macro deps; simplify test/canister dependency composition.
rs/nervous_system/neurons_fund/nfplot/BUILD.bazel Inline binary deps list (remove module-level DEPENDENCIES).
rs/nervous_system/long_message/BUILD.bazel Inline deps and simplify host/canister deps while preserving wasm select where needed.
rs/nervous_system/integration_tests/BUILD.bazel Inline proc-macro deps; remove empty dev-deps var and simplify deps expressions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nmattia nmattia added this pull request to the merge queue May 21, 2026
Merged via the queue into master with commit 98932e5 May 21, 2026
47 checks passed
@nmattia nmattia deleted the nm-gov-inline branch May 21, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants