feat: responses might be executed before canister_on_low_wasm_memory#271
Open
mraszyk wants to merge 2 commits into
Open
feat: responses might be executed before canister_on_low_wasm_memory#271mraszyk wants to merge 2 commits into
mraszyk wants to merge 2 commits into
Conversation
|
🤖 Here's your preview: https://soxyi-6iaaa-aaaam-ai2ra-cai.icp0.io |
There was a problem hiding this comment.
Pull request overview
This PR clarifies the IC interface specification around the On Low Wasm Memory hook by documenting and formalizing that response callbacks may still execute after the low-memory condition is met but before canister_on_low_wasm_memory actually runs (e.g., when the hook is scheduled but cannot yet be executed).
Changes:
- Add an explicit note to the canister interface docs stating that responses may execute between condition trigger and hook execution.
- Update the abstract behavior “Message execution” rule to allow executing response callbacks even when
on_low_wasm_memory_hook_statusisReady.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/references/ic-interface-spec/canister-interface.md | Adds documentation clarifying execution ordering around canister_on_low_wasm_memory vs responses. |
| docs/references/ic-interface-spec/abstract-behavior.md | Adjusts the formal “Message execution” conditions to permit response callback execution while the low-memory hook is pending. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specifies that responses might still be executed after the condition for
canister_on_low_wasm_memoryis triggered and before the functioncanister_on_low_wasm_memoryis actually executed.