Skip to content

Fixes case when font is different from attributed font. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
popwarfour wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes case when font is different from attributed font. #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions Sources/UITextView+Placeholder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,22 +87,22 @@ - (UILabel *)placeholderLabel {
NSAttributedString *originalText = self.attributedText;
self.text = @" "; // lazily set font of `UITextView`.
self.attributedText = originalText;

label = [[UILabel alloc] init];
label.textColor = [self.class defaultPlaceholderColor];
label.numberOfLines = 0;
label.userInteractionEnabled = NO;
objc_setAssociatedObject(self, @selector(placeholderLabel), label, OBJC_ASSOCIATION_RETAIN_NONATOMIC);

self.needsUpdateFont = YES;
[self updatePlaceholderLabel];
self.needsUpdateFont = NO;

[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(updatePlaceholderLabel)
name:UITextViewTextDidChangeNotification
object:self];

for (NSString *key in self.class.observingKeys) {
[self addObserver:self forKeyPath:key options:NSKeyValueObservingOptionNew context:nil];
}
Expand Down Expand Up @@ -173,33 +173,39 @@ - (void)updatePlaceholderLabel {
[self.placeholderLabel removeFromSuperview];
return;
}

[self insertSubview:self.placeholderLabel atIndex:0];

if (self.needsUpdateFont) {
self.placeholderLabel.font = self.font;
[self.placeholderLabel.attributedText enumerateAttribute:NSFontAttributeName inRange:NSMakeRange(0, self.placeholderLabel.attributedText.length) options:0 usingBlock:^(id value, NSRange range, BOOL *stop) {
if(value != nil) {
self.placeholderLabel.font = (UIFont *)value;
} else {
self.placeholderLabel.font = self.font;
}
}];
self.needsUpdateFont = NO;
}
self.placeholderLabel.textAlignment = self.textAlignment;

// `NSTextContainer` is available since iOS 7
CGFloat lineFragmentPadding;
UIEdgeInsets textContainerInset;

#pragma deploymate push "ignored-api-availability"
// iOS 7+
if (NSFoundationVersionNumber > NSFoundationVersionNumber_iOS_6_1) {
lineFragmentPadding = self.textContainer.lineFragmentPadding;
textContainerInset = self.textContainerInset;
}
#pragma deploymate pop

// iOS 6
else {
lineFragmentPadding = 5;
textContainerInset = UIEdgeInsetsMake(8, 0, 8, 0);
}

CGFloat x = lineFragmentPadding + textContainerInset.left;
CGFloat y = textContainerInset.top;
CGFloat width = CGRectGetWidth(self.bounds) - x - lineFragmentPadding - textContainerInset.right;
Expand All @@ -208,3 +214,4 @@ - (void)updatePlaceholderLabel {
}

@end