Repository navigation
Fix the learning log render loop in the instructor preview - #244
Merged
Merged
Conversation
LearningLog defaulted initialAnswers to a new {} on every render, and it
compares that prop with the previous value during render. With no saved
answers (the instructor preview has none) it re-rendered until React gave
up, so every checklist showed 'This block could not be displayed'. The
default is now one shared object.
The instructor preview showed the course project goal in an open box above
every lesson. It is now the same collapsed 'Project overview' that the
learner reader uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small reader fixes found while reviewing courses in the instructor preview.
1. Learning log failed on every checklist
LearningLogdefaultsinitialAnswersto a new{}on every render, and then compares that prop with the previous value during render. With no saved answers (the instructor preview has none), it re-rendered until React stopped it, and each checklist showed "This block could not be displayed (LearningLog). Too many re-renders."The default is now one shared constant. When saved answers are passed (a learner's own session), nothing changes.
2. Project goal in the instructor preview
The instructor preview showed the course project goal in an always-open box above every lesson. The learner reader already folds it into a collapsed "Project overview". The preview now matches the reader.
Checked