Skip to content

refactor(platform): rename GetProInstance and update login hint text - #1823

Merged
skevetter merged 1 commit into
mainfrom
refactor/1551-platform-instance-hints
Nov 12, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/1551-platform-instance-hints

Conversation

@skevetter

@skevetter skevetter commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Cause

GetProInstance and the devsy pro login/start hints still use the old Pro name.

Fix

  • Rename GetProInstance to GetPlatformInstance and update its one caller.
  • Change the login hints in pkg/platform/client/client.go to devsy platform start and devsy platform login [devsy-platform-url].

Test evidence

9a184d924

  • go build ./...: pass
  • go test ./pkg/workspace/... ./cmd/workspace/up/...: 2 packages ok
  • coderabbit review --committed --base main: 0 findings
  • golangci-lint on touched packages: 6 existing cyclop/funlen issues in untouched files

Summary by CodeRabbit

  • Bug Fixes
    • Provider update checks now use the platform instance associated with the workspace’s provider, improving consistency when checking for updates.
    • Browser sign-in guidance and unauthenticated-client error messages now use platform terminology and provide platform-specific command examples. This makes the instructions clearer when authentication is needed and helps match the messages to the commands available in the platform client.

@netlify

netlify Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 9a184d9
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6af4f33c0e05eb798dc84a3c

@netlify

netlify Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 9a184d9
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6af4f33c6d7b5266795e0211

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The provider-instance lookup and its caller now use platform terminology. Browser-login guidance and unauthenticated-client errors now show platform-specific commands.

Changes: Platform terminology update

Layer / File(s) Summary
Platform provider lookup
pkg/workspace/provider_update.go, cmd/workspace/up/up_client.go
Renames GetProInstance to GetPlatformInstance. The caller retrieves a platform instance and passes it to CheckProviderUpdate.
Platform login guidance
pkg/platform/client/client.go
Replaces Pro login and start command examples with platform commands. Updates the platform URL placeholder.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Possibly related issues

  • Issue 1551 tracks the Pro-to-Platform rename and lists the provider lookup, caller, and login hints changed here.

Suggested labels: rename

Merge Risk: Minimal · up to 9a184

This is a terminology rename with updated CLI hint text. The hints point to commands that exist, and no behavior change or merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: renaming GetProInstance to GetPlatformInstance and updating the login hint text. It follows Conventional Commits format with the refactor(platform) type and scope. The…
Description check Passed The description covers the cause, the fix, and test evidence. It uses the repository's 'Cause' and 'Fix' sections instead of the template headings. It omits the template's 'What and why' heading, 'Typ…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: renaming GetProInstance to GetPlatformInstance and updating the login hint text. It follows Conventional Commits format with the refactor(platform) type and scope. The summary confirms the rename and the hint text change, so the title matches the changeset.

Full details: Description check

Explanation

The description covers the cause, the fix, and test evidence. It uses the repository's 'Cause' and 'Fix' sections instead of the template headings. It omits the template's 'What and why' heading, 'Type of change' checkboxes, 'AI assistance' section, the Testing checkboxes that name an integration test or an explicit no-test reason, and the Checklist. The test evidence lists unit-level commands only and does not name an e2e spec or explain why no integration test is needed. The change is a refactor, so the missing sections are non-critical, but the template is not fully followed.

Resolution

Add the template sections that apply: tick the Refactor type, complete the AI assistance section, and state under Testing that no integration test is needed, naming the existing spec that covers the rename. Also confirm the Checklist items, including the CLA. Remove the unused template comments.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b9095053-5a5a-4ff5-b098-6bda32454272
Commits

Reviewing files that changed from the base of the PR and between 0cc91ca and 9a184d9.

Files selected for processing: 3

  • cmd/workspace/up/up_client.go
  • pkg/platform/client/client.go
  • pkg/workspace/provider_update.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@skevetter
skevetter marked this pull request as ready for review November 12, 2026 01:49
@mergify

mergify Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

This pull request is merged.

@skevetter
skevetter merged commit 18daa59 into main Nov 12, 2026
58 checks passed
@skevetter
skevetter deleted the refactor/1551-platform-instance-hints branch November 12, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant