Skip to content

fix(desktop): require libuuid by soname in RPM - #1818

Merged
skevetter merged 1 commit into
devsy-org:mainfrom
saknopper:fix/rpm-libuuid-soname
Nov 11, 2026
Merged

skevetter merged 1 commit into
devsy-org:mainfrom
saknopper:fix/rpm-libuuid-soname

Conversation

@saknopper

@saknopper saknopper commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What and why

The Linux RPM can't be installed on openSUSE Tumbleweed: zypper reports nothing provides 'libuuid'. The RPM requires the package name libuuid, which is what Fedora/RHEL call it. openSUSE ships the same library as libuuid1.

This PR requires the shared library (soname) instead of the package name. Every distro's libuuid package declares that it provides it:

 rpm:
   depends:
     ...
     - at-spi2-core
-    - libuuid
+    - libuuid.so.1()(64bit)
Distro Package that provides libuuid.so.1()(64bit)
Fedora libuuid
openSUSE Tumbleweed libuuid1

The other RPM dependencies already resolve on openSUSE, so only libuuid changes. The DEB dependencies are untouched.

Fixes none

Type of change

  • Bug fix
  • New feature
  • Refactor (no behavior change)
  • Docs
  • CI / build / tooling
  • Breaking change (user-visible behavior, CLI flags, config, or provider contract)

AI assistance

  • No AI tools were used
  • AI tools were used (fill in below)
Field Answer
Tool and model GitHub Copilot (Copilot SDK in VS Code)
Used for debugging, wrote the change, verified it in containers
Share of change mostly generated
  • I read and understand every line of this change and can explain it in review.
  • I ran the code myself; generated tests were checked to fail without the fix.

Testing

  • CLI / provider / agent change: added or updated Ginkgo integration tests under e2e/tests/
  • Desktop change: added or updated Playwright e2e tests under desktop/e2e/
  • Added or updated unit tests (mise run cli:test / mise run desktop:test)
  • No integration test needed, because: this only changes RPM package metadata, and no test suite installs the RPM. The release.yml package verification step still builds and inspects the RPM.

How I verified it:

Before: installing the v1.26.0 release RPM on registry.opensuse.org/opensuse/tumbleweed:

$ zypper install --dry-run Devsy_linux_x86_64.rpm
Problem: 1: Detailed information:
- nothing provides 'libuuid' needed by the to be installed devsy-desktop-1.26.0-1.x86_64

After: I built a test RPM with the same fpm that electron-builder 26.17.0 downloads (fpm-1.17.0-ruby-3.4.3-linux-amd64.7z), in an ubuntu:24.04 container, passing the new depends list and --rpm-rpmbuild-define "_rpmformat 4". fpm writes the dependency into the spec unchanged:

$ rpm -qp --requires devsy-test.rpm | grep uuid
libuuid.so.1()(64bit)

Installing that RPM:

# openSUSE Tumbleweed
$ zypper install --allow-unsigned-rpm devsy-test.rpm   -> exit 0
$ rpm -q --whatprovides 'libuuid.so.1()(64bit)'       -> libuuid1-2.42.4-2.1.x86_64

# Fedora (registry.fedoraproject.org/fedora:latest)
$ dnf install devsy-test.rpm                          -> exit 0
$ rpm -q --whatprovides 'libuuid.so.1()(64bit)'       -> libuuid-2.42.4-1.fc45.x86_64

The test RPM contained a placeholder file instead of the app payload, so the full electron-builder desktop build was not run locally.

Checklist

  • mise run cli:lint:ci passes (and mise run desktop:check for desktop changes)
  • mise run cli:test passes
  • Docs under sites/ updated for user-visible changes
  • No secrets, tokens, or personal paths in code, logs, or screenshots
  • I have signed the CLA (the bot will comment if not)

Notes for reviewers

  • ()(64bit) is the soname suffix RPM uses on 64-bit platforms. That's correct here because the RPM targets x64 only. An arm64 RPM would also use (64bit).
  • electron-builder's built-in default for this entry is (libuuid or libuuid1), a boolean ("rich") dependency. This repo's depends override replaced it with plain libuuid.
  • Nothing in the RPM links libuuid. I checked devsy-desktop, libffmpeg.so, chrome_crashpad_handler, the node-pty modules and the static devsy CLI. Dropping the dependency would also be valid; I kept it to stay close to electron-builder's defaults.
  • The lint and test commands in the checklist were not run because they don't cover electron-builder.yml.

Summary by CodeRabbit

  • Bug Fixes
    • Improved RPM installation compatibility across Fedora/RHEL and openSUSE. Packages now recognize the required 64-bit UUID library across distributions that use different package names. This change affects installation dependency handling; it does not alter the app’s features or behavior.

The RPM required the Fedora package name "libuuid", which does not
exist on openSUSE (the library ships as "libuuid1"), so zypper reported
an unresolvable dependency. Require libuuid.so.1()(64bit) instead,
which every distribution's libuuid package provides.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@netlify

netlify Bot commented Nov 10, 2026

Copy link
Copy Markdown

👷 Deploy request for devsydev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a741000

@netlify

netlify Bot commented Nov 10, 2026

Copy link
Copy Markdown

👷 Deploy request for images-devsy-sh pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a741000

@devsy-app

devsy-app Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The RPM dependency changes from libuuid to libuuid.so.1()(64bit). A comment notes that Fedora/RHEL and openSUSE use different package names for the library.

Changes: RPM dependency

Layer / File(s) Summary
Update RPM dependency declaration
desktop/electron-builder.yml
The RPM dependency now uses the 64-bit libuuid.so.1()(64bit) capability. A comment notes package-name differences across distributions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested labels: bug, size/xs

Suggested reviewers: skevetter

Merge Risk: Minimal · up to a7410

The dependency change is intended to support both Fedora and openSUSE. No code-level merge blocker is established.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly and concisely describes the RPM dependency change from a package name to a soname requirement.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains the problem, the RPM dependency change, its scope, reported verification, testing rationale, and reviewer notes. It also completes the required change type and AI-assistance s…
Full details: Description check

Explanation

The description explains the problem, the RPM dependency change, its scope, reported verification, testing rationale, and reviewer notes. It also completes the required change type and AI-assistance sections. The unchecked commands and full desktop build are clearly disclosed.

Finishing Touches

Simplify code

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cdd5dbe3-50d3-46de-b6ce-c27b47e5da4d
Commits

Reviewing files that changed from the base of the PR and between 980c238 and a741000.

Files selected for processing: 1

  • desktop/electron-builder.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

This pull request is merged.

@saknopper

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

devsy-app Bot added a commit to devsy-org/cla-signatures that referenced this pull request Nov 10, 2026
@saknopper

Copy link
Copy Markdown
Contributor Author

recheck

@skevetter

Copy link
Copy Markdown
Contributor

Thank you.

@skevetter
skevetter merged commit 0cc91ca into devsy-org:main Nov 11, 2026
30 of 32 checks passed
@saknopper
saknopper deleted the fix/rpm-libuuid-soname branch November 11, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants