Repository navigation
fix(desktop): require libuuid by soname in RPM - #1818
Conversation
The RPM required the Fedora package name "libuuid", which does not exist on openSUSE (the library ships as "libuuid1"), so zypper reported an unresolvable dependency. Require libuuid.so.1()(64bit) instead, which every distribution's libuuid package provides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
👷 Deploy request for devsydev pending review.Visit the deploys page to approve it
|
👷 Deploy request for images-devsy-sh pending review.Visit the deploys page to approve it
|
|
All contributors have signed the CLA. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
This pull request is merged. |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Thank you. |
What and why
The Linux RPM can't be installed on openSUSE Tumbleweed: zypper reports
nothing provides 'libuuid'. The RPM requires the package namelibuuid, which is what Fedora/RHEL call it. openSUSE ships the same library aslibuuid1.This PR requires the shared library (soname) instead of the package name. Every distro's libuuid package declares that it provides it:
rpm: depends: ... - at-spi2-core - - libuuid + - libuuid.so.1()(64bit)libuuid.so.1()(64bit)libuuidlibuuid1The other RPM dependencies already resolve on openSUSE, so only
libuuidchanges. The DEB dependencies are untouched.Fixes none
Type of change
AI assistance
Testing
e2e/tests/desktop/e2e/mise run cli:test/mise run desktop:test)release.ymlpackage verification step still builds and inspects the RPM.How I verified it:
Before: installing the v1.26.0 release RPM on
registry.opensuse.org/opensuse/tumbleweed:After: I built a test RPM with the same fpm that electron-builder 26.17.0 downloads (
fpm-1.17.0-ruby-3.4.3-linux-amd64.7z), in anubuntu:24.04container, passing the newdependslist and--rpm-rpmbuild-define "_rpmformat 4". fpm writes the dependency into the spec unchanged:Installing that RPM:
The test RPM contained a placeholder file instead of the app payload, so the full
electron-builderdesktop build was not run locally.Checklist
mise run cli:lint:cipasses (andmise run desktop:checkfor desktop changes)mise run cli:testpassessites/updated for user-visible changesNotes for reviewers
()(64bit)is the soname suffix RPM uses on 64-bit platforms. That's correct here because the RPM targets x64 only. An arm64 RPM would also use(64bit).(libuuid or libuuid1), a boolean ("rich") dependency. This repo'sdependsoverride replaced it with plainlibuuid.libuuid. I checkeddevsy-desktop,libffmpeg.so,chrome_crashpad_handler, thenode-ptymodules and the staticdevsyCLI. Dropping the dependency would also be valid; I kept it to stay close to electron-builder's defaults.electron-builder.yml.Summary by CodeRabbit