Skip to content

fix(e2e): prevent blocked live output from hanging commands - #1809

Merged
skevetter merged 1 commit into
mainfrom
fix/e2e-blocked-output
Nov 10, 2026
Merged

skevetter merged 1 commit into
mainfrom
fix/e2e-blocked-output

Conversation

@skevetter

@skevetter skevetter commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlify Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 6949a95
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6af1ffa45873b5f518c6a58f

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@netlify

netlify Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 6949a95
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6af1ffa46b4c3779b286fe92

@skevetter
skevetter force-pushed the fix/e2e-blocked-output branch from 4421e10 to 5610454 Compare November 9, 2026 16:52
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 23 minutes.

@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

The PR separates complete output capture from best-effort live output. The latest change stops queued writes after the drain deadline and counts those queued bytes as dropped.

  • The command runner keeps full output even when a live writer stalls.
  • Framework command helpers keep captured output when console output stalls.

Reviews (3) · Last reviewed commit: "fix(e2e): prevent blocked live output fr..." · Reviewed by Greptile

Comment thread e2e/framework/internal/livetee/tee.go Resolved
Comment thread e2e/framework/runenv/exec.go Resolved
Comment thread e2e/framework/internal/livetee/tee.go Resolved
@skevetter
skevetter force-pushed the fix/e2e-blocked-output branch from 5610454 to b4e7cfd Compare November 9, 2026 17:04
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter
skevetter force-pushed the fix/e2e-blocked-output branch from b4e7cfd to 6949a95 Compare November 9, 2026 17:15
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 13 minutes.

@skevetter skevetter closed this Nov 9, 2026
@skevetter skevetter reopened this Nov 9, 2026
@skevetter
skevetter marked this pull request as ready for review November 10, 2026 03:36
@skevetter
skevetter merged commit 41640c7 into main Nov 10, 2026
177 of 178 checks passed
@skevetter
skevetter deleted the fix/e2e-blocked-output branch November 10, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant