Skip to content

fix(ci): resolve mise verification disk cleanup and provider test warnings - #1794

Merged
skevetter merged 1 commit into
mainfrom
fix/ci-warnings-pre-commit-provider-tests
Nov 8, 2026
Merged

skevetter merged 1 commit into
mainfrom
fix/ci-warnings-pre-commit-provider-tests

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Cause

  • Pinned jdx/mise-action at v5.0.1 checked cached binaries against latest release checksums without version keys, causing integrity warnings on cache hits.
  • ownedProviderUpdateServer kept HTTP keep-alives enabled, causing forceful resets and Windows socket exception crashes during teardown.
  • jlumbroso/free-disk-space attempted apt removal of powershell which is not an apt package on Ubuntu runners.

Fix

  • Bump jdx/mise-action to v5.2.7 in pr-ci.yml and act.yml.
  • Disable keep-alives in ownedProviderUpdateServer and remove CloseClientConnections.
  • Set large-packages: false and remove invalid step attribute in pr-ci.yml.

Test evidence

  • Commit 357fd5a
  • go test -count=1 ./pkg/workspace/...: pass (1 package)
  • go test -v ./hack/provider_update_ci/...: pass (18 tests)
  • GOOS=windows go vet ./pkg/workspace/... ./hack/provider_update_ci/...: pass
  • actionlint .github/workflows/pr-ci.yml .github/workflows/act.yml: pass
  • mise run cli:lint:ci: pass (0 issues)
  • prek run: pass (5 hooks)

Not verified

  • Windows-native runner execution of provider update tests.
  • Full matrix run on GitHub Actions.

@netlify

netlify Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 357fd5a
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6af01c5f427fe11c0c161cca

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 484e0466-c327-4665-97d6-f4c8df27a240
Commits

Reviewing files that changed from the base of the PR and between 5d7c6bf and 357fd5a.

Files selected for processing: 4

  • .github/workflows/act.yml
  • .github/workflows/pr-ci.yml
  • pkg/workspace/provider_update_extended_test.go
  • pkg/workspace/provider_update_preservation_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@netlify

netlify Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 357fd5a
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6af01c5f02bfb9a632ed3543

@github-actions github-actions Bot added the size/s label Nov 8, 2026
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Updates CI setup and HTTP test cleanup.

  • Both CI workflows set up tools with mise-action v5.2.7.
  • Linux integration cleanup leaves large packages alone.
  • Provider-update tests use shared HTTP servers that close without keep-alives.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "fix(ci): resolve mise verification disk ..." · Reviewed by Greptile

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 28 minutes.

@skevetter
skevetter marked this pull request as ready for review November 8, 2026 08:18
@skevetter
skevetter merged commit f4a5f0a into main Nov 8, 2026
117 checks passed
@skevetter
skevetter deleted the fix/ci-warnings-pre-commit-provider-tests branch November 8, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant