Skip to content

fix(desktop): write rpm SIZE tag by building rpm format 4 - #1767

Merged
skevetter merged 1 commit into
mainfrom
fix/rpm-size-tag
Nov 4, 2026
Merged

skevetter merged 1 commit into
mainfrom
fix/rpm-size-tag

Conversation

@skevetter

@skevetter skevetter commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Cause

The release runner image is Ubuntu 26.04 with rpm 6.0.1. fpm uses it, and rpm 6 writes the v6 format, which has LONGSIZE but no SIZE tag. rpm -qp --qf '%{SIZE}' prints (none), which breaks tools such as rechunk.

Fix

Pass _rpmformat 4 to rpmbuild through rpm.fpm in electron-builder.yml. The release workflow now fails if the built rpm has no SIZE.

Test evidence

Ubuntu 26.04 container, rpm 6.0.1, fpm: default format gave SIZE=(none) LONGSIZE=3; _rpmformat 4 gave SIZE=3. Release 1.24.0 header has tag 1009, 1.26.0 only 5009. Confirmed electron-builder 26.17.0 forwards options.fpm to fpm.

Not verified

Full electron-builder rpm build and the CI workflow run.

Summary by CodeRabbit

  • Bug Fixes
    • Improved checks for Linux desktop packages so invalid or empty packages are caught before release.
  • Chores
    • Updated Linux package metadata formatting for more consistent RPM packaging.

@netlify

netlify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 0b9d7c8
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6aeb5fe2376fe66cb5204eb5

@netlify

netlify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 0b9d7c8
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6aeb5fe23d606534e58bfa45

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

RPM packaging now sets the RPM format to version 4. The Linux release workflow checks that the RPM SIZE value is a positive integer before extracting packages.

Changes: RPM SIZE verification

Layer / File(s) Summary
Configure and verify RPM SIZE
desktop/electron-builder.yml, .github/workflows/release.yml
The packaging configuration sets the RPM format to version 4. Before extraction, the release workflow fails if the RPM SIZE value is missing, invalid, or not positive.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

  • devsy-org/devsy#1765 — The PR configures _rpmformat as 4 and checks the RPM SIZE value, matching the reported missing-SIZE symptom. Full RPM build verification is not stated.

Suggested labels: bug, size/xs

Merge Risk: Minimal · up to 0b9d7

No actionable merge-blocking issue was identified. The RPM format override is paired with a release check that rejects missing or invalid SIZE metadata.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description covers the cause, the fix, test evidence, and what was not verified. It does not follow the repository template. It has no "What and why" heading and no "Fixes #" or "Refs #" line. The… Restructure the description to follow the repository template. Add a "What and why" section, with the cause and fix. Add a "Fixes #N" or "Refs #N" line, or write "none". Tick one option under "Type of change" (CI / build / tooling or Bug fi…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title names the change: the RPM build now uses format 4 so the SIZE tag is written. The raw summary shows a release workflow check and an electron-builder fpm option, and the title covers the core…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the RPM build now uses format 4 so the SIZE tag is written. The raw summary shows a release workflow check and an electron-builder fpm option, and the title covers the core fix. The title says "fix(desktop)", which matches the desktop packaging change and follows the Conventional Commits style the template asks for.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description covers the cause, the fix, test evidence, and what was not verified. It does not follow the repository template. It has no "What and why" heading and no "Fixes #" or "Refs #" line. The Type of change, AI assistance, Testing, and Checklist sections are missing. The author does not say whether an integration or e2e test is needed, and gives no reason for skipping one. The description is mostly complete on substance, but it leaves out several required template sections.

Resolution

Restructure the description to follow the repository template. Add a "What and why" section, with the cause and fix. Add a "Fixes #N" or "Refs #N" line, or write "none". Tick one option under "Type of change" (CI / build / tooling or Bug fix). Complete the "AI assistance" section, either by ticking "No AI tools were used" or by filling in the table. Under "Testing", state why no integration test applies, and name the existing spec that covers it, or add a test. Complete the "Checklist" items, or state which ones do not apply. Remove the template comments and leave no placeholders.

Finishing Touches
Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 108a74e2-4a97-48ac-b10b-a8b615028032
Commits

Reviewing files that changed from the base of the PR and between 38976fe and 0b9d7c8.

Files selected for processing: 2
  • .github/workflows/release.yml
  • desktop/electron-builder.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@mergify

mergify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter skevetter linked an issue Nov 4, 2026 that may be closed by this pull request
2 tasks done
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Forces desktop RPM packages to use format 4 so they retain the SIZE tag.

  • Linux desktop RPMs include a usable SIZE value before release checks continue.

No actionable issues were found. The full electron-builder build and release workflow were not run.

Reviews (1) · Last reviewed commit: "fix(desktop): write rpm SIZE tag by buil..." · Reviewed by Greptile

@skevetter
skevetter merged commit cc09128 into main Nov 4, 2026
38 checks passed
@skevetter
skevetter deleted the fix/rpm-size-tag branch November 4, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: rpm size is empty

1 participant