You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(desktop): write rpm SIZE tag by building rpm format 4 - #1767
The release runner image is Ubuntu 26.04 with rpm 6.0.1. fpm uses it, and rpm 6 writes the v6 format, which has LONGSIZE but no SIZE tag. rpm -qp --qf '%{SIZE}' prints (none), which breaks tools such as rechunk.
Fix
Pass _rpmformat 4 to rpmbuild through rpm.fpm in electron-builder.yml. The release workflow now fails if the built rpm has no SIZE.
Test evidence
Ubuntu 26.04 container, rpm 6.0.1, fpm: default format gave SIZE=(none) LONGSIZE=3; _rpmformat 4 gave SIZE=3. Release 1.24.0 header has tag 1009, 1.26.0 only 5009. Confirmed electron-builder 26.17.0 forwards options.fpm to fpm.
Not verified
Full electron-builder rpm build and the CI workflow run.
Summary by CodeRabbit
Bug Fixes
Improved checks for Linux desktop packages so invalid or empty packages are caught before release.
Chores
Updated Linux package metadata formatting for more consistent RPM packaging.
No actionable comments were generated in the recent review.
Walkthrough
RPM packaging now sets the RPM format to version 4. The Linux release workflow checks that the RPM SIZE value is a positive integer before extracting packages.
Changes: RPM SIZE verification
Layer / File(s)
Summary
Configure and verify RPM SIZE desktop/electron-builder.yml, .github/workflows/release.yml
The packaging configuration sets the RPM format to version 4. Before extraction, the release workflow fails if the RPM SIZE value is missing, invalid, or not positive.
devsy-org/devsy#1765 — The PR configures _rpmformat as 4 and checks the RPM SIZE value, matching the reported missing-SIZE symptom. Full RPM build verification is not stated.
Suggested labels:bug, size/xs
Merge Risk: Minimal · up to 0b9d7
No actionable merge-blocking issue was identified. The RPM format override is paired with a release check that rejects missing or invalid SIZE metadata.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description covers the cause, the fix, test evidence, and what was not verified. It does not follow the repository template. It has no "What and why" heading and no "Fixes #" or "Refs #" line. The…
Restructure the description to follow the repository template. Add a "What and why" section, with the cause and fix. Add a "Fixes #N" or "Refs #N" line, or write "none". Tick one option under "Type of change" (CI / build / tooling or Bug fi…
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title names the change: the RPM build now uses format 4 so the SIZE tag is written. The raw summary shows a release workflow check and an electron-builder fpm option, and the title covers the core…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the change: the RPM build now uses format 4 so the SIZE tag is written. The raw summary shows a release workflow check and an electron-builder fpm option, and the title covers the core fix. The title says "fix(desktop)", which matches the desktop packaging change and follows the Conventional Commits style the template asks for.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: Description check
Explanation
The description covers the cause, the fix, test evidence, and what was not verified. It does not follow the repository template. It has no "What and why" heading and no "Fixes #" or "Refs #" line. The Type of change, AI assistance, Testing, and Checklist sections are missing. The author does not say whether an integration or e2e test is needed, and gives no reason for skipping one. The description is mostly complete on substance, but it leaves out several required template sections.
Resolution
Restructure the description to follow the repository template. Add a "What and why" section, with the cause and fix. Add a "Fixes #N" or "Refs #N" line, or write "none". Tick one option under "Type of change" (CI / build / tooling or Bug fix). Complete the "AI assistance" section, either by ticking "No AI tools were used" or by filling in the table. Under "Testing", state why no integration test applies, and name the existing spec that covers it, or add a test. Complete the "Checklist" items, or state which ones do not apply. Remove the template comments and leave no placeholders.
Finishing Touches
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 108a74e2-4a97-48ac-b10b-a8b615028032
Commits
Reviewing files that changed from the base of the PR and between 38976fe and 0b9d7c8.
Files selected for processing: 2
.github/workflows/release.yml
desktop/electron-builder.yml
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The release runner image is Ubuntu 26.04 with rpm 6.0.1. fpm uses it, and rpm 6 writes the v6 format, which has LONGSIZE but no SIZE tag.
rpm -qp --qf '%{SIZE}'prints(none), which breaks tools such as rechunk.Fix
Pass
_rpmformat 4to rpmbuild throughrpm.fpmin electron-builder.yml. The release workflow now fails if the built rpm has no SIZE.Test evidence
Ubuntu 26.04 container, rpm 6.0.1, fpm: default format gave
SIZE=(none) LONGSIZE=3;_rpmformat 4gaveSIZE=3. Release 1.24.0 header has tag 1009, 1.26.0 only 5009. Confirmed electron-builder 26.17.0 forwardsoptions.fpmto fpm.Not verified
Full electron-builder rpm build and the CI workflow run.
Summary by CodeRabbit