Skip to content

feat(provider): add Harvester setup preset and documentation - #1746

Merged
skevetter merged 2 commits into
mainfrom
feat/harvester-provider-repo
Nov 2, 2026
Merged

skevetter merged 2 commits into
mainfrom
feat/harvester-provider-repo

Conversation

@skevetter

@skevetter skevetter commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Cause

Harvester's provider was not listed as a Desktop preset or in Devsy's provider documentation.

Fix

Add the Harvester Remote preset and installation guidance. Provider discovery already enumerates standalone repositories in devsy-org. Provider icons already load from provider releases.

Test evidence

Head commit 17fab137179242467e0872d2289b95b3b6b139a0.
mise exec -- npm test -- src/renderer/src/lib/components/provider/ProviderWizard.test.ts: 33 passed, 0 failed.
mise run desktop:check: 5,101 files, 0 errors, 0 warnings from svelte-check; Biome 0 errors, 3 existing warnings.
mise run cli:lint:ci: 0 issues.
mise exec -- prek run --files desktop/src/renderer/src/lib/components/provider/ProviderWizard.svelte desktop/src/renderer/src/lib/components/provider/ProviderWizard.test.ts sites/docs-devsy-sh/content/docs/managing-providers/manage-providers.mdx: 7 passed, 0 failed.
/tmp/devsy-harvester-adoption provider list --available --result-format json: harvester listed.
/tmp/devsy-harvester-adoption provider add harvester --use=false --home /tmp/devsy-harvester-v1.CBItKquy: v1.0.0 installed.
/tmp/devsy-harvester-adoption provider icon harvester --theme light --result-format json --home /tmp/devsy-harvester-v1.CBItKquy | jq '{revision,mimeType,svgBytes:(.dataBase64|@base64d|length),missing}': cached SVG, 3,754 bytes.
/tmp/devsy-harvester-adoption provider icon harvester --theme dark --result-format json --home /tmp/devsy-harvester-v1.CBItKquy | jq '{revision,missing,mimeType}': missing dark variant; same revision.

Not verified

Harvester cluster provisioning, physical macOS Desktop UI, human CLA signing, and deployment.

Summary by CodeRabbit

  • New Features
    • Added Harvester HCI clusters as a selectable remote provider preset.
  • Documentation
    • Added Harvester setup instructions, including prerequisites for connecting a cluster and launching VMs.

@netlify

netlify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 17fab13
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ae81a8f6f975cfc969a8885

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 777bbfa2-4b05-43ba-bfbe-e7af0ebf35db
Commits

Reviewing files that changed from the base of the PR and between b6722c4 and 17fab13.

Files selected for processing: 3
  • desktop/src/renderer/src/lib/components/provider/ProviderWizard.svelte
  • desktop/src/renderer/src/lib/components/provider/ProviderWizard.test.ts
  • sites/docs-devsy-sh/content/docs/managing-providers/manage-providers.mdx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The Desktop provider wizard now offers Harvester as a Remote preset. The provider guide lists Harvester and documents its add command and setup requirements.

Changes: Harvester provider setup

Layer / File(s) Summary
Wizard preset and selection
desktop/src/renderer/src/lib/components/provider/ProviderWizard.svelte, desktop/src/renderer/src/lib/components/provider/ProviderWizard.test.ts
The wizard adds Harvester as a Remote preset. A test checks that it appears once when provider discovery also lists it, and that selecting it calls providerAdd with "harvester", an undefined source, and reuse disabled.
Provider setup documentation
sites/docs-devsy-sh/content/docs/managing-providers/manage-providers.mdx
The available providers list includes Harvester. Its setup section documents the add command and prerequisites: a cluster kubeconfig, an imported guest image, a reachable VM network, and a guest running SSH and Docker.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related issues

Possibly related PRs

  • devsy-org/devsy#1721: This PR adds provider-owned icon metadata and rendering, which is connected to the Harvester provider preset’s expected release artwork path.
Merge Risk: Minimal · up to 17fab

No actionable merge-blocking issue was identified in the Harvester setup additions. The change appears mergeable subject to normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "feat(provider): add Harvester setup preset and documentation" matches the main change. The diff adds a Harvester Remote preset to the provider wizard, adds a test for it, and documents the …
Description check Passed The description follows the template's main sections: What and why (Cause and Fix), Testing evidence, and Not verified. It states the problem and the fix, and it lists concrete test and lint results w…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat(provider): add Harvester setup preset and documentation" matches the main change. The diff adds a Harvester Remote preset to the provider wizard, adds a test for it, and documents the Harvester provider add command. It follows Conventional Commits form and is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description follows the template's main sections: What and why (Cause and Fix), Testing evidence, and Not verified. It states the problem and the fix, and it lists concrete test and lint results with a head commit. Several template items are missing or unclear: the "Fixes #" or "Refs #" line has no issue reference or "none", the Type of change checkboxes are not ticked, the AI assistance section is absent, and the Testing checkboxes for e2e coverage (Playwright under desktop/e2e/) are not ticked. The author also reports no e2e test was added for the desktop change, and the template requires integration coverage for desktop changes. The description is mostly complete, so it passes, but these gaps should be filled.

Resolution

Consider filling in the following before merge: the "Fixes #" or "Refs #" line (or "none"), the Type of change selection (New feature and Docs), the AI assistance section (state whether AI tools were used), and the Testing section. For the Testing section, either add or reference a Playwright e2e test under desktop/e2e/ for the new preset, or explain why none is needed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Finishing Touches
Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@netlify

netlify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 17fab13
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ae81a8fd096244bc8f5b1ff

@github-actions github-actions Bot added the size/s label Nov 2, 2026
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues remain.

Summary

Adds Harvester to Desktop’s Remote presets and documents its setup needs.

  • The provider wizard offers Harvester as a Remote choice.

Reviews (3) · Last reviewed commit: "test(provider): await catalog before che..." · Reviewed by Greptile

@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter
skevetter marked this pull request as ready for review November 2, 2026 05:41
@mergify

mergify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter
skevetter merged commit 7735997 into main Nov 2, 2026
38 checks passed
@skevetter
skevetter deleted the feat/harvester-provider-repo branch November 2, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant