Skip to content

feat(cli): add progress visibility control - #1736

Merged
skevetter merged 2 commits into
mainfrom
feat/1734-no-status-flag
Oct 31, 2026
Merged

skevetter merged 2 commits into
mainfrom
feat/1734-no-status-flag

Conversation

@skevetter

@skevetter skevetter commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Cause

Progress reporters write independently of diagnostic severity. CI also creates a nested workspace reporter.

Fix

Add a global --no-status flag at presentation sinks. Preserve diagnostics, child streams, results, journal and task recording, and Desktop status envelopes. Document the output controls and add regression coverage.

Test evidence

Commit: 33a2258

  • mise exec -- go test ./pkg/status ./pkg/flags/names ./cmd ./cmd/ci ./cmd/config ./cmd/internal ./cmd/provider ./cmd/workspace ./cmd/workspace/up: 9 packages passed, 0 failed.
  • mise exec -- go test -run '^$' ./e2e/tests/ci ./e2e/tests/up ./e2e/tests/ssh: 3 packages compiled, 0 failed.
  • mise run cli:lint:ci: 0 issues.
  • mise exec -- prek run --all-files: 13 hooks passed, 0 failed.
  • mise run desktop:check: 2 checks passed, 0 failed, 3 existing warnings.
  • mise exec -- npx playwright test e2e/no-status-protocol.e2e.ts --reporter=list --output /tmp/devsy-no-status-playwright-results: 1 passed, 0 failed.
  • "$CI_TOOL" e2e run --label ci --runner ubuntu-latest --e2e-dir ./e2e: 23 passed, 0 failed, 521 filtered out in GitHub Actions.

Not verified

Live provider execution outside the CI fixtures and deployment are not verified.

@netlify

netlify Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 33a2258
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ae51f899f662938de7bbd6c

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 202d5a63-b58b-4f0f-9cc3-0ff2bff31b60
Commits

Reviewing files that changed from the base of the PR and between e82ef4a and 33a2258.

Files selected for processing: 38
  • cmd/ci/ci.go
  • cmd/ci/status.go
  • cmd/ci/status_test.go
  • cmd/config/apply.go
  • cmd/config/apply_test.go
  • cmd/flag_aliases_test.go
  • cmd/flags/flags.go
  • cmd/internal/runusercommands.go
  • cmd/internal/status_no_status_test.go
  • cmd/provider/add.go
  • cmd/provider/init.go
  • cmd/provider/set_source.go
  • cmd/provider/status.go
  • cmd/provider/status_no_status_test.go
  • cmd/workspace/build.go
  • cmd/workspace/delete.go
  • cmd/workspace/delete_test.go
  • cmd/workspace/exec.go
  • cmd/workspace/import.go
  • cmd/workspace/status_no_status_test.go
  • cmd/workspace/status_reporter.go
  • cmd/workspace/stop.go
  • cmd/workspace/task_tail_test.go
  • cmd/workspace/up/detach_test.go
  • cmd/workspace/up/early_task_test.go
  • cmd/workspace/up/status.go
  • cmd/workspace/up/status_no_status_test.go
  • cmd/workspace/up/up.go
  • desktop/e2e/no-status-protocol.e2e.ts
  • e2e/tests/ci/ci.go
  • e2e/tests/ssh/task_cancel.go
  • e2e/tests/up/up.go
  • pkg/flags/names/names.go
  • pkg/flags/names/names_test.go
  • pkg/status/render.go
  • pkg/status/reporter_test.go
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/continuous-integration.mdx
  • sites/docs-devsy-sh/content/docs/troubleshooting/troubleshooting.mdx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The change adds a global --no-status flag and passes it to CLI status reporters. It suppresses progress presentation while retaining diagnostics, results, and recorded events. Workspace-up worker runs continue to report worker status.

Changes: Status suppression

Layer / File(s) Summary
Flag and reporter suppression policy
cmd/flags/flags.go, cmd/flag_aliases_test.go, pkg/flags/names/*, pkg/status/render.go, pkg/status/reporter_test.go
The global flag and status reporter options carry NoStatus. Tests check flag parsing, output suppression, reporter validation, and nested event recording.
Command reporter wiring
cmd/ci/*, cmd/config/*, cmd/internal/*, cmd/provider/*, cmd/workspace/{build,delete,exec,import,status_reporter,stop}.go, cmd/workspace/{delete,status_no_status,task_tail}_test.go
Commands pass NoStatus to their reporters. Tests cover plain and JSON suppression and workspace status envelopes.
Workspace-up and worker status behavior
cmd/workspace/up/{status,up}.go, cmd/workspace/up/*_test.go, e2e/tests/{up/up.go,ssh/task_cancel.go}
Workspace-up suppresses foreground progress when NoStatus is set, but active worker runs retain status output. Tests check journal events and nested worker completion status.
Integration coverage and documentation
e2e/tests/ci/ci.go, desktop/e2e/no-status-protocol.e2e.ts, sites/docs-devsy-sh/content/docs/{developing-in-workspaces/continuous-integration,troubleshooting/troubleshooting}.mdx
End-to-end tests cover CI command output, errors, interruption, cleanup, Desktop provider status, and recorded workspace events. Documentation describes the flag’s effects and examples.

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant CLI
  participant StatusReporter
  participant EventJournal
  CLI->>StatusReporter: Run command with --no-status
  StatusReporter->>CLI: Suppress progress presentation
  StatusReporter->>EventJournal: Retain supported status events
Loading

Possibly related issues

Possibly related PRs

  • devsy-org/devsy#1609 — Changes workspace-up task attachment and lifecycle behavior that affects when the NoStatus worker-task condition applies.
Merge Risk: Minimal · up to 33a22

The change controls progress presentation while preserving diagnostics and recorded status. No concrete merge-blocking risk remains established; merge after normal checks.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Warning The description clearly explains the cause, fix, scope, and test results. It does not follow the repository template and omits the required issue reference, change-type selection, AI assistance detail… Update the description to use the repository template. Add a Fixes #N, Refs #N, or none entry; select the applicable change types; complete the AI assistance section and attestations; identify the integration, desktop, and unit tests …
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding CLI progress visibility control. It also follows the repository's Conventional Commits format.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 22 functions across 36 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Full details: Description check

Explanation

The description clearly explains the cause, fix, scope, and test results. It does not follow the repository template and omits the required issue reference, change-type selection, AI assistance details and attestations, checklist status, manual verification details, and reviewer notes.

Resolution

Update the description to use the repository template. Add a Fixes #N, Refs #N, or none entry; select the applicable change types; complete the AI assistance section and attestations; identify the integration, desktop, and unit tests with commands; document manual verification; and complete the checklist items. Keep the existing cause, fix, test evidence, and verification limitations.

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 33a2258
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ae51f89f9b516b8a25a0a59

@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The flag changes progress display across several CLI workflows.

The PR appears safe to merge, with a non-blocking gap in progress suppression for live task following.

Findings

  1. P2 Task progress stays visible ▶

Summary

Adds global --no-status control at CLI progress reporters.

  • CLI commands can hide live progress with one global flag.
  • CI hides both its own and nested workspace progress.
  • Workspace-up history remains available when progress is hidden.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Events[Status events] --> Journal[Journal and task recording]
  Events --> Sink[CLI progress reporter]
  Sink --> Check{Desktop mode?}
  Check -->|Yes| Desktop[Status envelopes]
  Check -->|No| Flag{NoStatus?}
  Flag -->|Yes| Hidden[No progress output]
  Flag -->|No| Visible[Progress output]
Loading

Reviews (1) · Last reviewed commit: "test(ci): distinguish diagnostics from s..." · Reviewed by Greptile

Comment thread cmd/flags/flags.go Resolved
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@skevetter
skevetter marked this pull request as ready for review October 31, 2026 03:13
@skevetter
skevetter merged commit 6b01bf7 into main Oct 31, 2026
118 checks passed
@skevetter
skevetter deleted the feat/1734-no-status-flag branch October 31, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant