Repository navigation
feat(cli): add progress visibility control - #1736
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Flag and reporter suppression policy cmd/flags/flags.go, cmd/flag_aliases_test.go, pkg/flags/names/*, pkg/status/render.go, pkg/status/reporter_test.go |
The global flag and status reporter options carry NoStatus. Tests check flag parsing, output suppression, reporter validation, and nested event recording. |
Command reporter wiring cmd/ci/*, cmd/config/*, cmd/internal/*, cmd/provider/*, cmd/workspace/{build,delete,exec,import,status_reporter,stop}.go, cmd/workspace/{delete,status_no_status,task_tail}_test.go |
Commands pass NoStatus to their reporters. Tests cover plain and JSON suppression and workspace status envelopes. |
Workspace-up and worker status behavior cmd/workspace/up/{status,up}.go, cmd/workspace/up/*_test.go, e2e/tests/{up/up.go,ssh/task_cancel.go} |
Workspace-up suppresses foreground progress when NoStatus is set, but active worker runs retain status output. Tests check journal events and nested worker completion status. |
Integration coverage and documentation e2e/tests/ci/ci.go, desktop/e2e/no-status-protocol.e2e.ts, sites/docs-devsy-sh/content/docs/{developing-in-workspaces/continuous-integration,troubleshooting/troubleshooting}.mdx |
End-to-end tests cover CI command output, errors, interruption, cleanup, Desktop provider status, and recorded workspace events. Documentation describes the flag’s effects and examples. |
Estimated code review effort: 4 (Complex) | ~45 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant CLI
participant StatusReporter
participant EventJournal
CLI->>StatusReporter: Run command with --no-status
StatusReporter->>CLI: Suppress progress presentation
StatusReporter->>EventJournal: Retain supported status events
Possibly related issues
- [Feature]: Add --no-status without suppressing diagnostics or recorded events #1734 — Requests
--no-statusbehavior, including progress suppression while preserving diagnostics, results, child streams, recorded events, and Desktop protocol output.
Possibly related PRs
- devsy-org/devsy#1609 — Changes workspace-up task attachment and lifecycle behavior that affects when the
NoStatusworker-task condition applies.
Merge Risk: 
Minimal · up to 33a22
-
The change controls progress presentation while preserving diagnostics and recorded status. No concrete merge-blocking risk remains established; merge after normal checks.
Pre-merge checks: 
3 · 
2
-
Failed checks: 2 warnings Passed checks: 3 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 22 functions across 36 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Full details: Description check
-
Explanation
The description clearly explains the cause, fix, scope, and test results. It does not follow the repository template and omits the required issue reference, change-type selection, AI assistance details and attestations, checklist status, manual verification details, and reviewer notes.
Resolution
Update the description to use the repository template. Add a
Fixes #N,Refs #N, ornoneentry; select the applicable change types; complete the AI assistance section and attestations; identify the integration, desktop, and unit tests with commands; document manual verification; and complete the checklist items. Keep the existing cause, fix, test evidence, and verification limitations.
-
Finishing Touches
-
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
✅ Deploy Preview for images-devsy-sh canceled.
|
|
@greptileai review |
[Medium impact] The flag changes progress display across several CLI workflows. The PR appears safe to merge, with a non-blocking gap in progress suppression for live task following. Findings
SummaryAdds global
|
|
@coderabbitai full review |
✅ Action performed
|
Cause
Progress reporters write independently of diagnostic severity. CI also creates a nested workspace reporter.
Fix
Add a global
--no-statusflag at presentation sinks. Preserve diagnostics, child streams, results, journal and task recording, and Desktop status envelopes. Document the output controls and add regression coverage.Test evidence
Commit: 33a2258
mise exec -- go test ./pkg/status ./pkg/flags/names ./cmd ./cmd/ci ./cmd/config ./cmd/internal ./cmd/provider ./cmd/workspace ./cmd/workspace/up: 9 packages passed, 0 failed.mise exec -- go test -run '^$' ./e2e/tests/ci ./e2e/tests/up ./e2e/tests/ssh: 3 packages compiled, 0 failed.mise run cli:lint:ci: 0 issues.mise exec -- prek run --all-files: 13 hooks passed, 0 failed.mise run desktop:check: 2 checks passed, 0 failed, 3 existing warnings.mise exec -- npx playwright test e2e/no-status-protocol.e2e.ts --reporter=list --output /tmp/devsy-no-status-playwright-results: 1 passed, 0 failed."$CI_TOOL" e2e run --label ci --runner ubuntu-latest --e2e-dir ./e2e: 23 passed, 0 failed, 521 filtered out in GitHub Actions.Not verified
Live provider execution outside the CI fixtures and deployment are not verified.