Repository navigation
fix(ci): retry provider update tests once on Windows Go runtime crash #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
skevetter
merged 2 commits into
main
from
fix/flake-windows-provider-update-runtime-crash
Oct 23, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "io" | ||
| "strings" | ||
| ) | ||
|
|
||
| const ( | ||
| maxTestAttempts = 2 | ||
| windowsAccessViolated = 0xc0000005 | ||
| ) | ||
|
|
||
| // Prefixes the Go runtime prints when the test process itself dies. The raw | ||
| // pointer panic value is the heap-corruption symptom seen in | ||
| // golang/go#81238; test code never panics with one. | ||
| var runtimeFatalPrefixes = []string{ | ||
| "fatal error:", | ||
| "Exception 0xc0000005", | ||
| "panic: (interface {}) 0x", | ||
| } | ||
|
|
||
| // runGoTestsWithRetry reruns the tests once when the Go runtime itself crashed. | ||
| // Windows/amd64 AMX runners corrupt the heap when an exception frame overflows | ||
| // the goroutine stack reserve (golang/go#81238, unfixed). Remove this retry once | ||
| // a released Go toolchain contains the upstream fix. | ||
| func runGoTestsWithRetry( | ||
| logFile io.Writer, | ||
| capture *outputCapture, | ||
| stdout, stderr io.Writer, | ||
| ) (testRunResult, *outputCapture) { | ||
| for attempt := 1; ; attempt++ { | ||
| result := runGoTests(capture) | ||
| capture.finish() | ||
| result.exitCode = executionExitCode(result) | ||
| if attempt == maxTestAttempts || !isRuntimeCrash(result, capture) { | ||
| return result, capture | ||
| } | ||
| reportf( | ||
| stderr, | ||
| "::warning::Go runtime crashed on Windows (golang/go#81238); "+ | ||
| "retrying provider update tests (attempt %d of %d)\n", | ||
| attempt+1, | ||
| maxTestAttempts, | ||
| ) | ||
| capture = newOutputCapture(logFile, stdout, stderr) | ||
| } | ||
| } | ||
|
|
||
| func isRuntimeCrash(result testRunResult, capture *outputCapture) bool { | ||
| if result.exitCode == 0 || result.startErr != nil || capture.err() != nil { | ||
| return false | ||
| } | ||
| for _, state := range capture.events() { | ||
| if state.failed { | ||
| return false | ||
| } | ||
| } | ||
| return uint32(result.exitCode) == windowsAccessViolated || capture.sawRuntimeFatal() | ||
|
skevetter marked this conversation as resolved.
Resolved
|
||
| } | ||
|
|
||
| func isRuntimeFatalLine(line string) bool { | ||
| for _, prefix := range runtimeFatalPrefixes { | ||
| if strings.HasPrefix(line, prefix) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Limit retries to the targeted runtime-crash signature.
If a test triggers
fatal error: concurrent map writes, this prefix qualifies it for a retry. A passing second attempt can then hide the test race. The Go runtime uses this same prefix for concurrent-map failures, while the reported Windows issue showsfatal error: found pointer to free object. Match the targeted symptom instead of everyfatal error:line. (github.com)🤖 Prompt for AI Agents